Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected typos in Omniauth.md #3716

Closed
wants to merge 1 commit into from
Closed

Conversation

SidharthBansal
Copy link
Member

Fixes #[Add issue number here.]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@ghost ghost assigned SidharthBansal Oct 19, 2018
@ghost ghost added the in progress label Oct 19, 2018
@plotsbot
Copy link
Collaborator

3 Messages
📖 @SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Oops! Conflicts! Also you could use first-timers-bot with this one if you'd like but we can also just merge quickly if you think it's not very interesting for new people 👍

@SidharthBansal
Copy link
Member Author

Moved to #3731.
Last year this month we had around 1330 issue and prs in this plots2 repo. Community is getting bigger spontaneously. Glad to see that.

@SidharthBansal
Copy link
Member Author

Moved to #3731.
Last year this month we had around 1330 issue and prs in this plots2 repo. Community is getting bigger spontaneously. Glad to see that.

@SidharthBansal
Copy link
Member Author

My github is giving me trouble from 7-8 hours. Sorry.

@emilyashley emilyashley deleted the SidharthBansal-patch-4 branch January 15, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants