Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trending tags showing duplicates #3963

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

vatbq
Copy link
Contributor

@vatbq vatbq commented Nov 13, 2018

Fixes #3188

@plotsbot
Copy link
Collaborator

plotsbot commented Nov 13, 2018

1 Message
📖 @ValentinaTironi Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Hi, I wonder instead of uniq which will just eliminate duplicates, we might use .distinct which would query the database for only unique records. Would you want to give that a try? Thanks!!

@vatbq
Copy link
Contributor Author

vatbq commented Nov 16, 2018

@jywarren Yes, of course!

@milaaraujo
Copy link
Collaborator

Hey @jywarren, can we merge this?

@jywarren jywarren merged commit 4d94a8a into publiclab:master Nov 20, 2018
@ghost ghost removed the ready label Nov 20, 2018
@jywarren
Copy link
Member

Yes, excellent, thank you! Sorry, we have a bit of a PR backlog, thanks for your patience!!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Trending tags showing duplicates

* use distinct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants