Access Token Popup (GCI)

[harshkhandeparkar]

Fixes #3586

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

PR for GCI task.

[plotsbot]

	2 Messages
📖	@harshkhandeparkar Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

[jywarren]

Hi, do you think you could put the key sections of this into a partial, named something like _token.html.erb and include it in here with <%= render partial: 'users/token' %> ? That'll help the profile template not get too overwhelmed! You can see other examples of partials throughout the templates if that helps!

Thanks!!

[jywarren]

And great work!!!

[harshkhandeparkar]

Hi, do you think you could put the key sections of this into a partial, named something like _token.html.erb and include it in here with <%= render partial: 'users/token' %> ? That'll help the profile template not get too overwhelmed! You can see other examples of partials throughout the templates if that helps!

Thanks!!

I have done so.

[harshkhandeparkar]

@publiclab/reviewers please review and approve my task.

[harshkhandeparkar]

Added new functionality:
Clicking the area surrounding the popup closes the popup.

plots2/app/views/users/_token.html.erb

Line 31 in 01270db

$('#token-mask').on('click', closePopup);

plots2/app/views/users/_token.html.erb

Lines 46 to 58 in 01270db

	function closePopup(e){
	var tokenPopup = document.querySelector('#token-popup .modal-content');
	if (tokenPopup === e.target || tokenPopup.contains(e.target) && e.target.id !== 'close-btn'){
	return;
	};
	$('#token-popup .modal-content').animate({marginTop: '0', opacity: '0'}, 300, function(){
	$(this).remove();
	$('#token-mask').fadeOut(200, function(){
	$(this).remove();
	});
	});
	};

[harshkhandeparkar]

@publiclab/reviewers please review.

[avsingh999]

great work @harshkhandeparkar 👍
@SidharthBansal @jywarren it looks good to me 😄 , I think ready to merge
thank you

[harshkhandeparkar]

Thanks for reviewing promptly.

[grvsachdeva]

Awesome work 🎉

[jywarren]

Fantastic. 👍 👍 🎉