Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete on post pages #4055

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

kevinzluo
Copy link
Collaborator

@kevinzluo kevinzluo commented Nov 26, 2018

Fixes #2795 (<=== Add issue number here)

I checked the properties of the search bar on the post page and found it was different from that on all other pages.

On Post:
image

On other pages:
image

I determined the cause of this change to be typeahead.jquery.js here.

<script src="/lib/typeahead.js/dist/typeahead.jquery.js"></script>

Upon removing this file, autocomplete appears to work.

autocompleteonpost

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

2 Messages
📖 @kevinzluo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@Souravirus
Copy link
Member

Nice work @kevinzluo. @jywarren, please see to this.

@jywarren jywarren merged commit 87db564 into publiclab:master Nov 26, 2018
@ghost ghost removed the ready label Nov 26, 2018
@jywarren
Copy link
Member

Great catch!!!

jonxuxu pushed a commit to jonxuxu/plots2 that referenced this pull request Dec 2, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants