Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined wiki/note grids #4056

Merged
merged 3 commits into from Nov 26, 2018
Merged

Combined wiki/note grids #4056

merged 3 commits into from Nov 26, 2018

Conversation

vatbq
Copy link
Contributor

@vatbq vatbq commented Nov 26, 2018

Fixes #3758

Here is a gif showing how it works.
wiki_notes

Test works:
screen shot 2018-11-26 at 5 23 00 pm

@vatbq vatbq mentioned this pull request Nov 26, 2018
@vatbq
Copy link
Contributor Author

vatbq commented Nov 26, 2018

Here @jywarren

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
1 Message
📖 @ValentinaTironi Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

@jywarren
Copy link
Member

Fantastic work! And so fast!

@jywarren jywarren merged commit cb1b998 into publiclab:master Nov 26, 2018
@ghost ghost removed the ready label Nov 26, 2018
@jywarren
Copy link
Member

I'm not sure if they're still working on it but there was an issue with thumbnail grid display -- formatting it with Bootstrap -- maybe you'd be interested in helping out?

#3970 (comment)

Right now the table CSS they were using is actually disrupting other table display, so it'd be preferable to move that to a bootstrap-based layout as in the comment i left. If you're interested, we could definitely use your help!

@vatbq
Copy link
Contributor Author

vatbq commented Nov 26, 2018

@jywarren Thank you very much to all! Actually, I'm trying to focus on the tasks of the Google code because it would be great to be able to fulfill that dream and I'm trying my best! But I think I could take a look at that issue, obviously! Thanks for opportunity 💯

@jywarren
Copy link
Member

jywarren commented Nov 26, 2018 via email

@vatbq
Copy link
Contributor Author

vatbq commented Nov 26, 2018

Omg, it would be really great! Thank u 💯

@jywarren
Copy link
Member

@vatbq
Copy link
Contributor Author

vatbq commented Nov 26, 2018

I can't claim that task without approve this in gci! (COMBINED WIKI/NOTE GRIDS USING [NODE:_____] SYNTAX, FOR INLINE GRIDS)
screen shot 2018-11-26 at 6 38 29 pm

@jywarren
Copy link
Member

jywarren commented Nov 26, 2018 via email

@vatbq
Copy link
Contributor Author

vatbq commented Nov 26, 2018

Thank you Jeff! I'm gonna work in that issue now!

jonxuxu pushed a commit to jonxuxu/plots2 that referenced this pull request Dec 2, 2018
* Combined wiki/note grids

* add test
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Combined wiki/note grids

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants