-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined wiki/note grids #4056
Combined wiki/note grids #4056
Conversation
Here @jywarren |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
Fantastic work! And so fast! |
I'm not sure if they're still working on it but there was an issue with thumbnail grid display -- formatting it with Bootstrap -- maybe you'd be interested in helping out? Right now the table CSS they were using is actually disrupting other table display, so it'd be preferable to move that to a bootstrap-based layout as in the comment i left. If you're interested, we could definitely use your help! |
@jywarren Thank you very much to all! Actually, I'm trying to focus on the tasks of the Google code because it would be great to be able to fulfill that dream and I'm trying my best! But I think I could take a look at that issue, obviously! Thanks for opportunity 💯 |
if you'd like we can make a google code-in issue for it?
…On Mon, Nov 26, 2018 at 4:25 PM Valentina Tironi ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Thank you very much to all!
Actually, I'm trying to focus on the tasks of the Google code because it
would be great to be able to fulfill that dream and I'm trying my best! But
I think I could take a look at that issue, obviously! Thanks for
opportunity 💯
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4056 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ8bomQOLXxtha5zLqlXbTOq4Ym0aks5uzFwwgaJpZM4YzxMI>
.
|
Omg, it would be really great! Thank u 💯 |
Approving now!
…On Mon, Nov 26, 2018 at 4:38 PM Valentina Tironi ***@***.***> wrote:
I can't claim that task without approve this in gci! (COMBINED WIKI/NOTE
GRIDS USING [NODE:_____] SYNTAX, FOR INLINE GRIDS)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4056 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJy7g7_jVRzVbYvl1rPEgf84WlYEgks5uzF9OgaJpZM4YzxMI>
.
|
Thank you Jeff! I'm gonna work in that issue now! |
* Combined wiki/note grids * add test
* Combined wiki/note grids * add test
Fixes #3758
Here is a gif showing how it works.
Test works: