Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #4285 Use same styles for buttons at /profile #4288

Merged
merged 1 commit into from
Dec 12, 2018
Merged

fixes #4285 Use same styles for buttons at /profile #4288

merged 1 commit into from
Dec 12, 2018

Conversation

IshaGupta18
Copy link
Collaborator

Fixes #4285
The buttons below tag at /profile had inconsistent styles.
image

They now have the same button class, thus removing the inconsistency.

image

@IshaGupta18 IshaGupta18 mentioned this pull request Dec 12, 2018
Closed
5 tasks
@plotsbot
Copy link
Collaborator

1 Message
📖 @IshaGupta18 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

oorjitchowdhary
oorjitchowdhary approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@oorjitchowdhary oorjitchowdhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.. Great work @IshaGupta18 🎉
@publiclab/reviewers I think we can merge this one!

grvsachdeva
grvsachdeva approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @IshaGupta18 🎉 !

@grvsachdeva
Copy link
Member

@IshaGupta18 you have to open your PR against plots2/master to get it merged. Thanks!

@IshaGupta18
Copy link
Collaborator Author

@gauravano could you please tell me how am I supposed to do that? Thank you!

@grvsachdeva
Copy link
Member

Oops, you opened PR against right branch already. I got confused with other PR review process.

@grvsachdeva grvsachdeva merged commit 9101cc1 into publiclab:master Dec 12, 2018
@grvsachdeva
Copy link
Member

Merged 🎉 💯 .

@SidharthBansal
Copy link
Member

She wrote branch name same as issue number

@oorjitchowdhary
Copy link
Member

Cheers...

@IshaGupta18
Copy link
Collaborator Author

Thank you so very much @oorjitchowdhary , @SidharthBansal and @gauravano for the appreciation and help. I am truly grateful for this motivation and I hope to contribute more to this wonderful community!

@grvsachdeva
Copy link
Member

We would also love to have your help with more issues @IshaGupta18. You can find more issues at https://code.publiclab.org/#r=all. Thanks!

@IshaGupta18
Copy link
Collaborator Author

Sure @gauravano ! Thank you again!

oorjitchowdhary pushed a commit to oorjitchowdhary/plots2 that referenced this pull request Dec 21, 2018
@IshaGupta18 @oorjitchowdhary
fixes publiclab#4285 Use same styles for buttons at /profile (publicl…
581be00 
…ab#4288)
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@IshaGupta18 @grvsachdeva
fixes publiclab#4285 Use same styles for buttons at /profile (publicl…
dc3787d 
…ab#4288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grvsachdeva grvsachdeva grvsachdeva approved these changes

@oorjitchowdhary oorjitchowdhary oorjitchowdhary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IshaGupta18 @plotsbot @grvsachdeva @SidharthBansal @oorjitchowdhary