Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Follow' icon is the same as 'number of views' icon(4278) #4294

Merged
merged 2 commits into from
Dec 18, 2018
Merged

'Follow' icon is the same as 'number of views' icon(4278) #4294

merged 2 commits into from
Dec 18, 2018

Conversation

IshaGupta18
Copy link
Collaborator

Fixes #4278

Earlier, 'Follow' icon was the same as 'number of views' icon.

image
image

To avoid any confusion for the users, the 'Follow' icon has now been updated to this:

image

image

@IshaGupta18 IshaGupta18 mentioned this pull request Dec 13, 2018
Closed
5 tasks
@plotsbot
Copy link
Collaborator

1 Message
📖 @IshaGupta18 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@oorjitchowdhary
Copy link
Member

@IshaGupta18 great work..
May I make one request -- please don't write the issue number as the pull request title.. That caused a lot of confusion for me..
You can use the same title as the issue for the PR if you like..

Thanks a lot

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented Dec 13, 2018 •
edited

Thank you for the suggestion @oorjitchowdhary . I realise that it sure can cause confusion. I'll ensure it won't happen again and I hope I haven't caused too much trouble. My apologies.

@oorjitchowdhary
Copy link
Member

@IshaGupta18 You can still edit it.. go to the title

@IshaGupta18 IshaGupta18 changed the title #4278 'Follow' icon is the same as 'number of views' icon(4278) Dec 13, 2018
@IshaGupta18
Copy link
Collaborator Author

I have changed the title, is it okay now?

@oorjitchowdhary
Copy link
Member

Yes, thanks a lot..

@IshaGupta18
Copy link
Collaborator Author

Thank you very much! I will be careful from next time onwards.

@IshaGupta18
Copy link
Collaborator Author

Is the work okay @oorjitchowdhary ? Is it ready to be merged or are there any changes required from my side? Thank you for your time!

avsingh999
avsingh999 approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@avsingh999 avsingh999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren @SidharthBansal It's look good to me : )

@IshaGupta18
Copy link
Collaborator Author

@avsingh999 Thank you sir!

@IshaGupta18
Copy link
Collaborator Author

Is this PR ready to be merged? @SidharthBansal @avsingh999

@SidharthBansal SidharthBansal merged commit 699108b into publiclab:master Dec 18, 2018
@SidharthBansal
Copy link
Member

Thanks a lot all.
Please take new issues from the issue tracker if you are willing to help us more.
Thanks

@IshaGupta18
Copy link
Collaborator Author

Yes absolutely sir! Thank you !

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@IshaGupta18 @SidharthBansal
'Follow' icon is the same as 'number of views' icon(4278) (publiclab…
3ea33cd 
…#4294)

* fixes publiclab#4285 Use same styles for buttons at /profile

* fixes publiclab#4278 'Follow' icon is the same as 'number of views' icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsingh999 avsingh999 avsingh999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IshaGupta18 @plotsbot @oorjitchowdhary @SidharthBansal @avsingh999