Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline character to message displayed on the dashboard #4981

Conversation

madeofhuman
Copy link
Contributor

@madeofhuman madeofhuman commented Mar 10, 2019

Fixes #4977

Before:
Screenshot 2019-03-10 at 1 22 02 AM

After:
Screenshot 2019-03-10 at 8 41 34 AM

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 10, 2019

1 Message
📖 @madeofhuman Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@madeofhuman
Copy link
Contributor Author

Hi, @gauravano, could you please review this, thanks.

Copy link
Member

@ananyaarun ananyaarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madeofhuman , I think it would be better if the line "You've shared 0 research notes." is on the next line as shown in the screen shot i attached in the issue template. Although since this is a UI change it requires discussion.
Here take a look, this is what i meant.
new1final

@grvsachdeva
Copy link
Member

We have to wait a bit to get a word from @jywarren as this is a UI change. @madeofhuman, you can start working on other issues in the meantime. Thanks!

@madeofhuman madeofhuman force-pushed the 4977-add-newline-character-to-dashboard-message branch from d54d2d5 to fe161b0 Compare March 10, 2019 07:43
@madeofhuman
Copy link
Contributor Author

I've updated it @ananyaarun. Thanks for the feedback.

@madeofhuman
Copy link
Contributor Author

We have to wait a bit to get a word from @jywarren as this is a UI change. @madeofhuman, you can start working on other issues in the meantime. Thanks!

All right, @gauravano. I'll look for another issue. Thank you.

@grvsachdeva
Copy link
Member

Great!

@jywarren
Copy link
Member

Hi! I appreciate this, but I think it pushes down the rest of the page a bit much. Also, i want to be aware that we are soon going to be doing a bigger redesign of the dashboard at #4922, so perhaps we could start preparing for that instead?

Thank you!!!

@madeofhuman
Copy link
Contributor Author

Sure, man @jywarren. No problem. Looking forward to working on the new designs.

@grvsachdeva
Copy link
Member

Thanks for raising PR @madeofhuman. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants