-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pointer cursor #5455
Added pointer cursor #5455
Conversation
Added pointer cursor to Choose Image
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattMski , good job with the changes!! , Pls follow the PR template and add a gif/screenshot of the changes made, Thanks :)
I have updated my pull request with the template, hopefully it's good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's awesome @MattMski !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @MattMski!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Merged 🎉 🎈 👍 @MattMski a suggestion: It's good to create a separate feature branch and create a PR using that as that way you'll be able to keep your master branch clean. Thanks! |
Okay, I'm still new into contribution, so I'll try to do that next time. Thank you! |
Added pointer cursor to Choose Image
Added pointer cursor to Choose Image
Fixes #5439
Added pointer cursor to Choose Image using internal css styling
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!