Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pointer cursor #5455

Merged
merged 1 commit into from Apr 12, 2019
Merged

Added pointer cursor #5455

merged 1 commit into from Apr 12, 2019

Conversation

MattMski
Copy link
Collaborator

@MattMski MattMski commented Apr 11, 2019

Fixes #5439
Added pointer cursor to Choose Image using internal css styling

cursor_ani

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Added pointer cursor to Choose Image
@welcome
Copy link

welcome bot commented Apr 11, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

3 Messages
📖 @MattMski Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@MattMski MattMski changed the title Added pointer cursor Added pointer cursor Fixes #5439 Apr 11, 2019
@MattMski MattMski changed the title Added pointer cursor Fixes #5439 Added pointer cursor Apr 11, 2019
Copy link
Member

@ananyaarun ananyaarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattMski , good job with the changes!! , Pls follow the PR template and add a gif/screenshot of the changes made, Thanks :)

@MattMski
Copy link
Collaborator Author

I have updated my pull request with the template, hopefully it's good

Copy link
Contributor

@divyabaid16 divyabaid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome @MattMski !!

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @MattMski!

@grvsachdeva grvsachdeva merged commit 1b8f555 into publiclab:master Apr 12, 2019
@welcome
Copy link

welcome bot commented Apr 12, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@grvsachdeva
Copy link
Member

Merged 🎉 🎈 👍

@MattMski a suggestion: It's good to create a separate feature branch and create a PR using that as that way you'll be able to keep your master branch clean.

Thanks!

@MattMski
Copy link
Collaborator Author

Merged 🎉 🎈 👍

@MattMski a suggestion: It's good to create a separate feature branch and create a PR using that as that way you'll be able to keep your master branch clean.

Thanks!

Okay, I'm still new into contribution, so I'll try to do that next time. Thank you!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change curson to pointer in /signup page
5 participants