Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.yml - change key to subscribe_to_answer #5511

Closed
wants to merge 1 commit into from
Closed

Update en.yml - change key to subscribe_to_answer #5511

wants to merge 1 commit into from

Conversation

z119
Copy link

@z119 z119 commented Apr 18, 2019

Fixes #5489 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [X ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Apr 18, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

1 Message
📖 @z119 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@@ -377,7 +377,7 @@ en:
follow: "Follow"
none: "None"
users_following_tag: "Users following this tag"
ask_question: "Ask a question about <b>%{tag}</b>"
subscribe_to_answer: "Ask a question about <b>%{tag}</b>"
or_subscribe_to_answer: "<a style='margin-bottom:6px;' class='btn btn-default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@z119 , this line has to be changed. ie 'or_subscribe_to_answer' to 'subscribe_to_answer'

@grvsachdeva
Copy link
Member

Hi @z119, please remove the merge conflict here and also do the correction as @ananyaarun suggested. Thanks!

@grvsachdeva
Copy link
Member

Also, if you want we can close this PR and you can make the change in your another PR #5512 as that would be good? Thanks!

@grvsachdeva grvsachdeva changed the title #5489 Update en.yml - change key to subscribe_to_answer Update en.yml - change key to subscribe_to_answer Apr 23, 2019
@SidharthBansal
Copy link
Member

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab
cc/ @jywarren @gauravano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change key to subscribe_to_answer
5 participants