Remove tooltip on click from like button #5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a GIF for this @gautamig54 |
Generated by 🚫 Danger |
|
@divyabaid16 Here you go!
|
|
Awesome @gautamig54 😄 |
divyabaid16
approved these changes
Apr 18, 2019
Co-Authored-By: gautamig54 <35326753+gautamig54@users.noreply.github.com>
|
@publiclab/reviewers Kindly review this PR. Thanks! |
|
confirmed! So what this change does is it only shows the tooltip the first time the user hovers over the button, and then after that it won't show it again unless you reload. Previously, the tooltip just never went away until you left the page. Please see 2 gifs below demonstrating this. I think this change is fine and mergable! Before: After: |
sashadev-sky
approved these changes
Apr 20, 2019
|
@gauravano @jywarren please review for merge |
|
Fantastic!!!!!! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* remove tooltip on click * Update app/views/like/_like.html.erb Co-Authored-By: gautamig54 <35326753+gautamig54@users.noreply.github.com>
digitaldina
pushed a commit
to digitaldina/plots2
that referenced
this pull request
May 12, 2019
* remove tooltip on click * Update app/views/like/_like.html.erb Co-Authored-By: gautamig54 <35326753+gautamig54@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5497 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!