Trim container build process.

[icarito]

Fixes #5705, addresses #5683

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[alaxalves]

Why can't we place this installation in our Dockerfile instead of executing this every build run. It would make easier when we accomplish this publiclab/mapknitter#598

[icarito]

Thanks for the review!

This pulls libqt5webkit5 and hundreds of megabytes of libraries, and is not needed in production. At the moment it is saving some time and storage for building the container in production and making image more manageable for debugging it.

[icarito]

Anyway we can revisit when we do start using docker images (exciting!). For now this should help trim testing and simplify deployment to production (where phantomjs isn't needed).

[plotsbot]

	2 Messages
📖	@icarito Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	Pull Request is marked as Work in Progress

Generated by 🚫 Danger

[icarito]

Finally this sucesfully trims a few minutes out of testing by optimizing build time! I think it's ready to merge...

[jywarren]

Yes Awesome!!! We may be able to drop phantomjs too as system tests can replace teaspoon/mocha tests which use it. Anyways why would we run 2 parallel chrome environments now we've started using headless chrome. Great!!

…

On Tue, May 21, 2019, 9:42 AM Sebastian Silva ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .travis.yml <#5730 (comment)>: > @@ -31,6 +31,7 @@ install: - 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then gem install danger danger-junit; fi' script: + - docker-compose exec web bash -c "apt install -y phantomjs" Anyway we can revisit when we do start using docker images (exciting!). For now this should help trim testing and simplify deployment to production (where phantomjs isn't needed). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5730?email_source=notifications&email_token=AAAF6JZ2CYIAJ5BLUAS44VDPWP3YXA5CNFSM4HNJKFMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZHOUBY#discussion_r286030702>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J2ZUHLE5E4WJDRLTSTPWP3YXANCNFSM4HNJKFMA> .