Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent restart loop of mailman container #5841

Merged
merged 1 commit into from Jun 5, 2019

Conversation

icarito
Copy link
Member

@icarito icarito commented Jun 5, 2019

Should help avoid issues like #5817

Mailman is set to restart continually, this sets a limit of 5 consecutive restarts.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@jywarren
Copy link
Member

jywarren commented Jun 5, 2019

OK, cool, but we will know if it fails 5 times because of the SMTP test alert or some other means? Thanks!

@icarito
Copy link
Member Author

icarito commented Jun 5, 2019 via email

@jywarren
Copy link
Member

jywarren commented Jun 5, 2019

ok, so shall we merge this and prioritize a monitoring system? we could output into the log after the fetching in the ruby script, and watch that it succeeds in the publicly readable log

@jywarren jywarren merged commit e62bb49 into master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants