Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile page subtabs for authored, co-authored and drafts #5854

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Fix profile page subtabs for authored, co-authored and drafts #5854

merged 4 commits into from
Jun 13, 2019

Conversation

michelelong
Copy link
Contributor

@michelelong michelelong commented Jun 6, 2019 •
edited

Fixes #5770

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

profile-subtabs

CleverFool77
CleverFool77 reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@CleverFool77 CleverFool77 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelelong i guess we'll prefer button group only for the design. The earlier design looked better.
Just work on the broken links for toggle between authored and co-authored would be okay. So that bug can be fixed
what do you say ?

@michelelong
Copy link
Contributor Author

profile-boxes
The button outlines? Not sure what you mean.
All three links are fixed.

@CleverFool77
Copy link
Member

Hi @michelelong If the links are fixed then that's what we need. And the design will remain same as it was earlier and as you showed in second screenshot. Understood ?
Thanks !!

@michelelong
Copy link
Contributor Author

@publiclab/reviewers buttons and links are fixed

CleverFool77
CleverFool77 approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@CleverFool77 CleverFool77 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jywarren
I just fetched this PR and checked it locally.
It's working smoothly.
Great Work @michelelong
This is ready for merge.

@gautamig54
Copy link
Contributor

This looks good @michelelong .

@jywarren jywarren merged commit 10f27f3 into publiclab:master Jun 13, 2019
@jywarren
Copy link
Member

THANK YOU!!!! 🎉

@michelelong michelelong deleted the fix-profile-subtabs branch June 13, 2019 17:35
rarrunategu1 pushed a commit to rarrunategu1/plots2 that referenced this pull request Jun 14, 2019
@michelelong @rarrunategu1
Fix profile page subtabs for authored, co-authored and drafts (public…
51f75ba 
…lab#5854)

* Fix profile page subtabs

* Add back button outlines
sagarpreet-chadha pushed a commit that referenced this pull request Jun 29, 2019
@michelelong @sagarpreet-chadha
Fix profile page subtabs for authored, co-authored and drafts (#5854)
fd07cf5 
* Fix profile page subtabs

* Add back button outlines
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
@michelelong @enviro3
Fix profile page subtabs for authored, co-authored and drafts (public…
1c2ecff 
…lab#5854)

* Fix profile page subtabs

* Add back button outlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleverFool77 CleverFool77 CleverFool77 approved these changes

@gautamig54 gautamig54 gautamig54 approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile Page Issues
4 participants
@michelelong @CleverFool77 @gautamig54 @jywarren