Added Service worker for notification on mobile phones #6158
Conversation
|
@jywarren I guess this would work. Unable to test on mobile because on mobile it only works with https. |
|
But Working on desktop. |
|
Pushed to unstable but not able to test on unstable because of error while creating a comment. So can we merge this so that I can test for mobile on stable? Working on the desktop is tested. |
namangupta01
force-pushed
the
service_worker
branch
from
625302b
to
0c66548
Compare
|
Sure, but we don't have https on stable either. Is there a way to test locally on https using a passenger setting? |
|
I guess we have |
|
|
|
I tried with thin using force SSL but that was causing WebSocket upgrade error. |
|
oh whoa, it must be new!?
…On Mon, Aug 19, 2019 at 4:56 PM Naman Gupta ***@***.***> wrote:
I tried with thin using force SSL but that was causing WebSocket upgrade
error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6158?email_source=notifications&email_token=AAAF6JZ7HMQXIZYAZ5PTWM3QFMCHTA5CNFSM4INF2NL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UITYY#issuecomment-522750435>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZ5ISD5SLIUXKCOPA3QFMCHTANCNFSM4INF2NLQ>
.
|
|
OK! I'll merge this but please be careful to file any fixes swiftly before we publish to production in the next day or two! Thanks, Naman! |
|
Sure! 👍 |
|
Let's check on stable. Hopefully, it will work. |
|
Yayyy! It worked! 🎉 🎉 |
|
|
|
I got two duplicate notifications on the phone. Here I have fixed it #6159. |
|
whoa, awesome!!!
…On Mon, Aug 19, 2019 at 5:28 PM Naman Gupta ***@***.***> wrote:
I got two duplicate notifications on the phone. Here I have fixed it #6159
<#6159>.
Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#6158?email_source=notifications&email_token=AAAF6J3YJYIQLKT3OI7IXD3QFMF5JA5CNFSM4INF2NL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ULFJI#issuecomment-522760869>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J6N3S4GDMKEQXSNMKLQFMF5JANCNFSM4INF2NLQ>
.
|
Closes #6020