Dashboard initial design #6229
Dashboard initial design #6229
Conversation
|
The current screenshot :
We show the topic cards of the topics a user follows |
| @@ -0,0 +1,60 @@ | |||
| <div class="card-view" style="margin-left: -13px;"> | |||
| <% current_user.subscriptions(:tag).each do |tag| %> | |||
There was a problem hiding this comment.
We shouldn't have tags as per current user right ? It should be all the latest tags in dashboard I guess ?
There was a problem hiding this comment.
Hi! As from what I understood, it should be specific to a user. I had a discussion about the same with @gauravano as well. The topic cards should be the ones followed by the user and all the updates regarding that.
There was a problem hiding this comment.
Actually, let's ask @jywarren as he's available now for more clarity on this.
| </div> | ||
| <div class="card-body" style="padding:0.8em;"> | ||
| <div class="node-list"> | ||
| <% Tag.find_nodes_by_type(tag.tagname, type = 'note', limit = 3).each do |node| %> |
There was a problem hiding this comment.
In dashboard, we require all the nodes, Comments, wikis, Questions too I guess wiki too. I think this would be updated in profile page too. I'll update it for profile page.
There was a problem hiding this comment.
Okay! I'll add them as well. Thanks!
There was a problem hiding this comment.
Hi @CleverFool77! How do I add comments here, because we cannot associate comments with any topic?
There was a problem hiding this comment.
Shall we approach this the same way as on the profile page, by making a new page similar to /comments, but for /comments/warren for example -- all comments by an author? Then we can link there from the dashboard AND from the profile page.
There was a problem hiding this comment.
We could make it a pretty simple page, just a table like /comments maybe?
| </div> | ||
| </div> | ||
| <div class="card-footer" style="background-color: inherit; border:none;"> | ||
| <a style="text-decoration: underline; color: #808080; display: inline-block;" href="/tag/<%= tag.tagname %>"><%= Tag.follower_count(tag.tagname).to_i-1 %> <%= t('tag.index.more_posts') %> <i class="fa fa-angle-double-right"></i></a> |
There was a problem hiding this comment.
Similar as above, Not just notes, but need to include comments,questions too.
This will be added in profile page soon too.
There was a problem hiding this comment.
Questions and notes have already been added!
There was a problem hiding this comment.
Here notes are covering all the posts made. I think the only portion not covered here are the wikis and the comments. We can discuss about them with @jywarren !
|
Hi @gautamig54 I requested some changes for the cards. |
app/views/dashboard/_header.html.erb
Outdated
| @@ -1,14 +1,15 @@ | |||
| <div class="row header"> | |||
|
|
|||
| <% if current_user %> | |||
| <h1><%= t('dashboard._header.dashboard') %></h1> | |||
| <h4><%= t('dashboard._header.dashboard') %></h4>   | |||
There was a problem hiding this comment.
If I'm not wrong, ends with a semicolon.
There was a problem hiding this comment.
yeah it's
cc: @gautamig54
| <% end %> | ||
|
|
||
| </div> | ||
|
|
||
| <div class="row stats"> | ||
| <!-- <div class="row stats"> | ||
| <h4 class="col-lg-8"> |
There was a problem hiding this comment.
Hi @gautamig54 May I know why is this section commented ? 🤔
There was a problem hiding this comment.
We do not have the welcome text as such in the new design. It is more like an alert message. I'll add the alert message text. Should I completely delete this part?
| <small><a href="/tags" class="form-grey" style="margin-left:-13px;">Trending topics:</a></small> | ||
| <span class="topics-span"> | ||
| <% cache('trending-tags', expires_in: 24.hours, skip_digest: true) do %> | ||
| <% Tag.trending.each do |i| %> |
There was a problem hiding this comment.
Maybe we can have better naming ? instead of i
Screenshots 📸 (click to expand)6229-test_viewing_question_post.png6229-test_signup_modal.png6229-test_wiki.png6229-test_tag_page.png6229-test_searching_an_item_from_the_homepage.png6229-test_blog_page_with_location_modal.png6229-test_login.png6229-test_wiki_page_with_inline_grids.png6229-test_questions.png6229-test_methods.png6229-test_tag_by_author_page.png6229-test_viewing_the_dropdown_menu.png6229-test_simple-data-grapher_powertag.png6229-test_viewing_the_settings_page.png6229-test_login_modal.png6229-test_comments.png6229-test_stats.png6229-test_tags.png6229-test_wiki_revisions.png6229-test_people.png6229-test_front.png6229-failures_test_viewing_the_dashboard.png6229-test_signup.png6229-test_questions_shadow.png6229-test_blog.png6229-test_question_page.png6229-test_front_page_with_navbar_search_autocomplete.png6229-test_viewing_the_dashboard.pngLearn about automated screenshots Generated by 🚫 Danger |
|
Hi @gautamig54 Is there any update on this ? Would you like me to take this up ? |
|
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
Fixes #6072 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!