-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow users feature #625
Follow users feature #625
Conversation
7f20bf5
to
8d2beb5
Compare
@jywarren This is how it looks |
8d2beb5
to
4ab7cbd
Compare
@jywarren This is good to go for review |
wow, exciting. I'll look over it tomorrow, thank you! On Thu, Jul 28, 2016 at 9:48 AM, Lalith Rallabhandi <
|
@@ -0,0 +1,3 @@ | |||
# Place all the behaviors and hooks related to the matching controller here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this and other empty files? We aren't currently using any .coffee or .scss files and these are just templates in any case. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, will update them
Hi! This is really nice, clean code. I left some suggestions -- thanks for this excellent update! @ebarry did you have any input on this, which closely mirrors "following" on Github, for example. |
4ab7cbd
to
533b786
Compare
PublicLab supports gravatar 🎉 Addressed your comments. |
c9af8b3
to
0224068
Compare
0224068
to
e8dd6fa
Compare
@@ -37,8 +37,11 @@ | |||
get 'people' => 'users#list' | |||
get 'users/role/:id' => 'users#list' | |||
match 'users/update' => 'users#update' | |||
match 'users/:id/following' => 'users#following', as: :following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebarry and @steviepubliclab, would you prefer "people" in the URL instead of "users"?
I think I like People :) |
e8dd6fa
to
e4c877e
Compare
People makes sense, I updated link to people and Good to merge ? |
Merged, thanks! I'll try to publish tomorrow so we can see this live, exciting. |
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test
schema.rb.example
has been updated if any database migrations were addedPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!