Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow users feature #625

Merged
merged 6 commits into from
Aug 2, 2016
Merged

Conversation

lalithr95
Copy link
Member

@lalithr95 lalithr95 commented Jul 22, 2016

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer
  • schema.rb.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@lalithr95
Copy link
Member Author

@jywarren This is how it looks

Follow interface
follow

Unfollow interface
screenshot at jul 27 23-38-43

@lalithr95 lalithr95 changed the title Follow users feature - WIP Follow users feature Jul 28, 2016
@lalithr95
Copy link
Member Author

@jywarren This is good to go for review

@jywarren
Copy link
Member

wow, exciting. I'll look over it tomorrow, thank you!

On Thu, Jul 28, 2016 at 9:48 AM, Lalith Rallabhandi <
notifications@github.com> wrote:

@jywarren https://github.com/jywarren This is good to go for review


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#625 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJx10U97E2I9OTEoaoYTaRm3SVD6Pks5qaLM9gaJpZM4JSZ8c
.

@jywarren
Copy link
Member

Very cool. Did you see where, in the "like" menu on research notes, there's a place where we'd be able to follow the author? Could you connect that up too? I'll review code tomorrow morning, thanks!

screenshot 2016-07-28 at 10 21 40 am

@@ -0,0 +1,3 @@
# Place all the behaviors and hooks related to the matching controller here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this and other empty files? We aren't currently using any .coffee or .scss files and these are just templates in any case. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will update them

@jywarren
Copy link
Member

Hi! This is really nice, clean code. I left some suggestions -- thanks for this excellent update! @ebarry did you have any input on this, which closely mirrors "following" on Github, for example.

@lalithr95
Copy link
Member Author

PublicLab supports gravatar 🎉 Addressed your comments.

@lalithr95 lalithr95 force-pushed the follow-users-feature branch 2 times, most recently from c9af8b3 to 0224068 Compare July 30, 2016 03:52
@@ -37,8 +37,11 @@
get 'people' => 'users#list'
get 'users/role/:id' => 'users#list'
match 'users/update' => 'users#update'
match 'users/:id/following' => 'users#following', as: :following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebarry and @steviepubliclab, would you prefer "people" in the URL instead of "users"?

@steviepubliclab
Copy link
Contributor

I think I like People :)

@lalithr95
Copy link
Member Author

People makes sense, I updated link to people and Good to merge ?

@jywarren jywarren merged commit fc049cc into publiclab:master Aug 2, 2016
@jywarren
Copy link
Member

jywarren commented Aug 2, 2016

Merged, thanks! I'll try to publish tomorrow so we can see this live, exciting.

@lalithr95 lalithr95 deleted the follow-users-feature branch August 2, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants