Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions to step 3 of standard installation. #6749

Conversation

bryceparkman
Copy link
Contributor

@bryceparkman bryceparkman commented Nov 8, 2019

Fixes #6748 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Nov 8, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃
It would be great if you can tell us your Twitter handle so we can thank you properly?

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Just a small refactor to make it more intuitive and I also fixed the indentation for "4. Steps to install gems:". (and updated it to 5 in accordance with the previous changes)

Let me know if these change requests are ok with you!

Thank you @bryceparkman :)

3. Enter the new **plots2** directory with `cd plots2`.
3. Enter the new **plots2** directory with `cd plots2` and then enter `git remote add upstream https://github.com/publiclab/plots2.git` in the command line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Enter the new **plots2** directory with `cd plots2`.
3. Enter the new **plots2** directory with `cd plots2` and then enter `git remote add upstream https://github.com/publiclab/plots2.git` in the command line.
3. Enter the new **plots2** directory with `cd plots2`.
4. Set the upstream remote to the original repo url so that git knows where to fetch updates from in the future: `git remote add upstream https://github.com/publiclab/plots2.git`

@@ -91,7 +91,7 @@ For information on how to install for use with the cloud environment, please see

1. Fork our repo from https://github.com/publiclab/plots2.
2. In the console, download a copy of your forked repo with `git clone https://github.com/your_username/plots2.git` where `your_username` is your GitHub username.
3. Enter the new **plots2** directory with `cd plots2`.
3. Enter the new **plots2** directory with `cd plots2` and then enter `git remote add upstream https://github.com/publiclab/plots2.git` in the command line.
4. Steps to install gems:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Steps to install gems:
5. Steps to install gems:

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions for adding git upstream remote in the README
3 participants