Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datauri posting! #6930

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Datauri posting! #6930

merged 2 commits into from
Dec 6, 2019

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Dec 6, 2019

Fixes #6594

@jywarren jywarren merged commit 9f503e5 into publiclab:master Dec 6, 2019
@jywarren
Copy link
Member Author

jywarren commented Dec 6, 2019

Uh oh, whoops! Need to switch it to the origin header, not the request host... coming up in a sec!

@jywarren
Copy link
Member Author

jywarren commented Dec 6, 2019

This might be impossible as currently imagined! See https://stackoverflow.com/questions/22397072/are-there-any-browsers-that-set-the-origin-header-to-null-for-privacy-sensitiv#22625354 -- the Referer header is not always there (esp cross http/https) and the Origin header is changed to null in some circumstances, which seems to be happening to us.

@jywarren jywarren mentioned this pull request Dec 6, 2019
Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
* initial work

* working exceptions for hostnames!
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
* initial work

* working exceptions for hostnames!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow data-url image upload using file input (from Infragram)
1 participant