Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tooltip for number of authors #7207

Merged
merged 1 commit into from Jan 16, 2020
Merged

add tooltip for number of authors #7207

merged 1 commit into from Jan 16, 2020

Conversation

priyanka-choubey
Copy link
Contributor

@priyanka-choubey priyanka-choubey commented Jan 12, 2020 •
edited

Fixes #7170

app/views/wiki/_header.html.erb modified to add a tooltip for number of authors.

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots attached

Screenshot from 2020-01-15 23-20-26

@welcome
Copy link

welcome bot commented Jan 12, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Jan 12, 2020 •
edited

Codecov Report

Merging #7207 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7207   +/-   ##
======================================
  Coverage    81.5%   81.5%           
======================================
  Files          97      97           
  Lines        5602    5602           
======================================
  Hits         4566    4566           
  Misses       1036    1036

@priyanka-choubey
Copy link
Contributor Author

@jywarren @nstjean @anthony-zhou kindly review :) Thanks!

VladimirMikulic
VladimirMikulic approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanka-choubey very nice 馃憤

anthony-zhou
anthony-zhou suggested changes Jan 13, 2020
View reviewed changes
Copy link
Member

@anthony-zhou anthony-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I mentioned one small fix in this review, please take a look! Thanks.

app/views/wiki/_header.html.erb Outdated
@@ -31,7 +31,7 @@

<div style="padding-top:8px;text-align:center">
<span class="d-none d-lg-inline">
<i style="color:#888;" class="fa fa-user"></i> <%= number_with_delimiter(@node.authors.length) %> |
<span rel="tooltip" title="The number of authors for this page." data-placement="top"><i style="color:#888;" class="fa fa-user"></i> <%= number_with_delimiter(@node.authors.length) %></span> ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have added an extra vertical bar ("|") after the tooltip.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should only be one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthony-zhou good catch. There should be only one vertical bar.

VladimirMikulic
VladimirMikulic requested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanka-choubey please do the changes that @anthony-zhou requested. Thanks.

@priyanka-choubey priyanka-choubey force-pushed the tooltip_wiki_header branch 3 times, most recently from ebd1108 to 87e1d68 Compare January 14, 2020 10:15
@priyanka-choubey priyanka-choubey requested a review from a team as a code owner January 14, 2020 10:15
@priyanka-choubey
Copy link
Contributor Author

@jywarren @anthony-zhou can you kindly review? Thanks :v

VladimirMikulic
VladimirMikulic reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanka-choubey could you please post a screenshot of your change? Thanks.

@priyanka-choubey
Copy link
Contributor Author

@VladimirMikulic screenshot is attached in pr description :)

@VladimirMikulic
Copy link
Contributor

@priyanka-choubey it's still the old screenshot :)

@priyanka-choubey
Copy link
Contributor Author

@VladimirMikulic ohh sorry about that 馃槄 updated pr description

emilyashley
emilyashley approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@emilyashley emilyashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

VladimirMikulic
VladimirMikulic approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanka-choubey 馃憤

@jywarren jywarren merged commit 732d33f into publiclab:master Jan 16, 2020
@welcome
Copy link

welcome bot commented Jan 16, 2020

Congrats on merging your first pull request! 馃檶馃帀鈿★笍
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 馃槂. Please find the link pinned in the issue section 馃摑
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

This is super. Thanks a ton, and great work! 馃帀

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
@priyanka-choubey
add tooltip for number of authors (publiclab#7207)
12a99e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-zhou anthony-zhou anthony-zhou requested changes

@jywarren jywarren jywarren approved these changes

@emilyashley emilyashley emilyashley approved these changes

@ananyaarun ananyaarun ananyaarun approved these changes

@VladimirMikulic VladimirMikulic VladimirMikulic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tooltip explaining number of wiki authors
6 participants
@priyanka-choubey @VladimirMikulic @jywarren @emilyashley @ananyaarun @anthony-zhou