Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

following table aligned in contributor page #7331

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

keshavsethi
Copy link
Member

Fixes #7297
Here following section is properly aligned
Screenshot from 2020-01-23 15-27-14

This is what I am getting please review this.
Thanks!

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #7331 into master will increase coverage by 0.13%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7331      +/-   ##
==========================================
+ Coverage   81.73%   81.87%   +0.13%     
==========================================
  Files          97       97              
  Lines        5602     5612      +10     
==========================================
+ Hits         4579     4595      +16     
+ Misses       1023     1017       -6
Impacted Files Coverage Δ
app/controllers/tag_controller.rb 80.49% <100%> (+0.18%) ⬆️
app/models/node.rb 90.9% <100%> (-0.02%) ⬇️
app/controllers/user_sessions_controller.rb 66.45% <100%> (ø) ⬆️
app/models/comment.rb 76.89% <75%> (-0.06%) ⬇️
app/api/srch/search.rb 69.28% <0%> (+4.57%) ⬆️
app/services/execute_search.rb 94.44% <0%> (+5.55%) ⬆️

@keshavsethi
Copy link
Member Author

Can anyone tell me why this check is showing error
Thanks

@keshavsethi
Copy link
Member Author

@jywarren @SidharthBansal @nstjean can you please tell me why this check is not successful and how to fix this

@nstjean
Copy link
Contributor

nstjean commented Jan 28, 2020

@keshav234156 It looks like an error, not your fault! @jywarren can you restart this test?

@keshav234156
Copy link
Member

@nstjean looks like you wanted to mention @keshavsethi instead of @keshav234156 (me)!!!

@nstjean
Copy link
Contributor

nstjean commented Jan 28, 2020

Whoops so sorry!

@SidharthBansal
Copy link
Member

Closing and Opening the pr is the simplest way to restart the travis if you don't have access

@nstjean
Copy link
Contributor

nstjean commented Jan 30, 2020

Oh, ok! Thank you for the tip!

@keshavsethi
Copy link
Member Author

Can we merge this? @nstjean @SidharthBansal

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @keshavsethi Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7331-test_questions.png

7331-test_embeddable_grids.png

7331-test_signup.png

7331-test_viewing_the_settings_page.png

7331-test_tag_by_author_page.png

7331-test_wiki_page_with_inline_grids.png

7331-test_stats.png

7331-test_viewing_the_dashboard.png

7331-test_searching_an_item_from_the_homepage.png

7331-test_signup_modal_form_validation.png

7331-test_tag_stats.png

7331-test_login_modal_form_validation.png

7331-test_questions_shadow.png

7331-test_login_modal.png

7331-test_profile_page.png

7331-test_comments.png

7331-test_tags.png

7331-test_signup_modal.png

7331-test_wiki.png

7331-test_methods.png

7331-test_tag_page.png

7331-test_blog_page_with_location_modal.png

7331-test_tag_wildcard.png

7331-test_signup_modal_disabled_submit_button_on_empty_username.png

7331-test_embeddable_thumbnail_grids.png

7331-test_front_page_with_navbar_search_autocomplete.png

7331-test_spam_moderation_page.png

7331-test_login.png

7331-test_viewing_the_dropdown_menu.png

7331-test_viewing_question_post.png

7331-test_mobile_displays.png

7331-test_simple-data-grapher_powertag.png

7331-test_front.png

7331-test_question_page.png

7331-test_tag_contributors_page.png

7331-test_blog.png

7331-test_people.png

7331-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@nstjean
Copy link
Contributor

nstjean commented Feb 17, 2020

@keshavsethi I'm thinking maybe we should put some more space between the two columns. Glancing at it it seems a little confusing. Do you think you can modify that?

@cesswairimu cesswairimu merged commit dc6a61f into publiclab:master Apr 13, 2020
@cesswairimu
Copy link
Collaborator

thanks @keshavsethi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People who are following column is not aligned properly
7 participants