Update tag_controller.rb #8221

yusufatalay · 2020-07-31T20:55:03Z

replaced the instances of .count and .length with .size

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

replaced the instances of .count and .length with .size

welcome · 2020-07-31T20:55:05Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

gitpod-io · 2020-07-31T20:55:08Z

yusufatalay · 2020-07-31T20:56:25Z

I've done my task.Thank you for giving me the oppurtunity to do this. can you rewiev the code and give some feedback to me ?.

codecov · 2020-07-31T20:59:25Z

Codecov Report

Merging #8221 into main will increase coverage by 0.05%.
The diff coverage is 83.80%.

@@            Coverage Diff             @@
##             main    #8221      +/-   ##
==========================================
+ Coverage   81.81%   81.87%   +0.05%     
==========================================
  Files         100      101       +1     
  Lines        5846     5902      +56     
==========================================
+ Hits         4783     4832      +49     
- Misses       1063     1070       +7

Impacted Files	Coverage Δ
app/controllers/users_controller.rb	`81.11% <ø> (-1.06%)`	⬇️
app/mailers/admin_mailer.rb	`90.90% <0.00%> (ø)`
app/controllers/spam2_controller.rb	`71.84% <44.44%> (-3.76%)`	⬇️
app/models/comment.rb	`77.51% <50.00%> (ø)`
app/controllers/notes_controller.rb	`83.40% <83.33%> (-0.01%)`	⬇️
app/controllers/tag_controller.rb	`81.45% <83.33%> (+0.11%)`	⬆️
app/models/user.rb	`87.68% <85.71%> (ø)`
app/controllers/batch_controller.rb	`90.19% <90.19%> (ø)`
app/controllers/wiki_controller.rb	`85.34% <92.30%> (+0.34%)`	⬆️
app/controllers/admin_controller.rb	`80.24% <100.00%> (ø)`
... and 11 more

cesswairimu · 2020-08-03T14:33:17Z

thanks so much @yusufatalay for opening this 🎉 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

cesswairimu · 2020-08-10T14:52:19Z

@yusufatalay please update the link to the issue you are solving. Thanks

yusufatalay · 2020-08-10T15:18:52Z

I am confused can you walk me through it ?

avats-dev · 2020-08-27T13:57:43Z

I am confused can you walk me through it ?

Hey @yusufatalay , thanks for your contribution and welcome to publiclab community. It's very important to link your PR to the issue that it intends to resolve, as this can:

help others check if PR is any good for what it is intended.
automatically close that issue when the PR is merged.
help in better workflow of the codebase.

To link your PR to the issue, edit your comment (the first one, i.e. one with which you have opened this PR) and you'll see something like "Fixes #0000 (<=== Add issue number here)". This is even the first line of your comment. You have to replace 0000 here with the issue number concerned with your PR, and leave everything else as it is. Don't remove the # as it is crucial and creates the link in between.

If you're still unsure and having problems, watch this as an example.

avats-dev

@yusufatalay , nice work. There're remaining instances of .count still in

plots2/app/controllers/tag_controller.rb

Lines 545 to 565 in ce68627

    
             def fetch_counts 
        
               # Enhancement #6306 - Add counts to `by type` dropdown on tag pages 
        
               @counts = {} 
        
               @counts[:posts] = Node.for_tagname_and_type(params[:id], 'note', wildcard: @wildcard).where('node.nid NOT IN (?)', @qids).count 
        
               @counts[:questions] = Node.for_tagname_and_type(params[:id], 'note', question: true, wildcard: @wildcard).where('node.nid IN (?)', @qids).count 
        
               @counts[:wiki] = Node.for_tagname_and_type(params[:id], 'page', wildcard: @wildcard).count 
        
               params[:counts] = @counts 
        
               # end Enhancement #6306 ============================================ 
        
               @total_posts = case @node_type 
        
               when 'note' 
        
                 @notes.count 
        
               when 'questions' 
        
                 @questions.count 
        
               when 'wiki' 
        
                 @wikis.count 
        
               when 'maps' 
        
                 @nodes.count 
        
               end 
        
             end 
        
           end

and similarly I've seen that there are some remaining instances of .length also in code.

TIP: Use Ctrl+F after you've done editing and search for .count and .length keywords to see if there're any.
CAUTION: There're chances that similar keywords are present like counts or even the count word in some variable or string. You should not edit them. I think these would be rare, if you search with the . in front.

Thanks, keep up the good work! 👍

avats-dev · 2020-08-27T14:22:24Z

Hey @yusufatalay , you've linked this PR with your PR, while you need to link the concerned issue to this PR. I checked and saw that the issue concerned with your PR is #8209. So, your comment should be like "Fixes #8209".

Thanks, good work. 👍

avats-dev · 2020-08-27T14:23:26Z

Also, @cesswairimu , review this when you're free.

yusufatalay · 2020-08-27T14:29:04Z

Thank you for guiding me it really helps me improve myself. Those .counts must be added after I edit the code , if not please let me know.

avats-dev · 2020-08-27T14:42:47Z

Hey @yusufatalay , these instances are not added after you've edited the code as these are also present in your fork https://github.com/yusufatalay/plots2/blob/patch-1/app/controllers/tag_controller.rb.

Now, you should checkout to your patch-1 branch and edit the changes needed. After that just commit and push the changes to your branch, and this PR will get updated itself.

Feel free to ping back if you're stuck or need any help. 👍

yusufatalay · 2020-08-27T15:01:57Z

I figure it out that on github ctrl+f won't work for whole code. So I copied it to a text editor then I've edited it there thank you for your help , I've learned alot from this.

avats-dev · 2020-08-27T17:25:33Z

I figure it out that on github ctrl+f won't work for whole code. So I copied it to a text editor then I've edited it there thank you for your help , I've learned alot from this.

@yusufatalay it's good to hear that you learnt a lot. Could you push your changes so that we can review it?

You've to push changes on this branch, then only this PR would self update itself.

Thanks 👍

avats-dev

Looks all good now @yusufatalay . 🎉 Thanks for the contribution.

@cesswairimu for review and merge!

avats-dev · 2020-08-30T02:59:33Z

@yusufatalay close #8360, as this PR is gonna solve the issue and would be merged hopefully! Thanks

avats-dev · 2020-08-30T16:08:36Z

@yusufatalay don't close this PR, this is good and it's working. Also tests have passed. Reopen this PR.

Close #8360, the new one that you've opened.

gitpod-io · 2020-08-30T16:12:45Z

avats-dev

Looks all good to me 🎉

@cesswairimu check this one and merge when you're free!

yusufatalay · 2020-09-01T13:16:34Z

Thank you for patiently teaching me.

cesswairimu · 2020-09-01T13:32:48Z

Really love the collaboration that has gone on here . Great job 🎉 🎉

cesswairimu

🚀

cesswairimu · 2020-09-01T13:33:56Z

Welcome to the community @yusufatalay 🎈

welcome · 2020-09-01T13:33:57Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

avats-dev · 2020-09-01T17:45:11Z

Welcome to the community @yusufatalay 🚀 and thanks @cesswairimu 😄

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

Update tag_controller.rb

c31ffb0

replaced the instances of .count and .length with .size

avats-dev suggested changes Aug 27, 2020

View reviewed changes

Update tag_controller.rb

50eb3b5

avats-dev approved these changes Aug 30, 2020

View reviewed changes

avats-dev mentioned this pull request Aug 30, 2020

Update tag_controller.rb #8360

Closed

5 tasks

yusufatalay closed this Aug 30, 2020

yusufatalay reopened this Aug 30, 2020

avats-dev approved these changes Sep 1, 2020

View reviewed changes

cesswairimu approved these changes Sep 1, 2020

View reviewed changes

cesswairimu merged commit c229df4 into publiclab:main Sep 1, 2020

nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020

Update tag_controller.rb (publiclab#8221)

b22da52

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020

Update tag_controller.rb (publiclab#8221)

69d1337

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020

Update tag_controller.rb (publiclab#8221)

e0a4a41

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020

Update tag_controller.rb (publiclab#8221)

4597986

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021

Update tag_controller.rb (publiclab#8221)

f39a0fd

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021

Update tag_controller.rb (publiclab#8221)

aadcae2

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021

Update tag_controller.rb (publiclab#8221)

d6f6f3a

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021

Update tag_controller.rb (publiclab#8221)

8d42844

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021

Update tag_controller.rb (publiclab#8221)

7a5a7f6

* Update tag_controller.rb replaced the instances of .count and .length with .size * Update tag_controller.rb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update tag_controller.rb #8221

Update tag_controller.rb #8221

yusufatalay commented Jul 31, 2020 •

edited

welcome bot commented Jul 31, 2020

gitpod-io bot commented Jul 31, 2020 •

edited

yusufatalay commented Jul 31, 2020

codecov bot commented Jul 31, 2020 •

edited

cesswairimu commented Aug 3, 2020

cesswairimu commented Aug 10, 2020

yusufatalay commented Aug 10, 2020 •

edited

avats-dev commented Aug 27, 2020

avats-dev left a comment

avats-dev commented Aug 27, 2020

avats-dev commented Aug 27, 2020

yusufatalay commented Aug 27, 2020

avats-dev commented Aug 27, 2020

yusufatalay commented Aug 27, 2020

avats-dev commented Aug 27, 2020

avats-dev left a comment

avats-dev commented Aug 30, 2020

avats-dev commented Aug 30, 2020

gitpod-io bot commented Aug 30, 2020

avats-dev left a comment

yusufatalay commented Sep 1, 2020

cesswairimu commented Sep 1, 2020

cesswairimu left a comment

cesswairimu commented Sep 1, 2020

welcome bot commented Sep 1, 2020

avats-dev commented Sep 1, 2020

	def fetch_counts
	# Enhancement #6306 - Add counts to `by type` dropdown on tag pages
	@counts = {}
	@counts[:posts] = Node.for_tagname_and_type(params[:id], 'note', wildcard: @wildcard).where('node.nid NOT IN (?)', @qids).count
	@counts[:questions] = Node.for_tagname_and_type(params[:id], 'note', question: true, wildcard: @wildcard).where('node.nid IN (?)', @qids).count
	@counts[:wiki] = Node.for_tagname_and_type(params[:id], 'page', wildcard: @wildcard).count
	params[:counts] = @counts
	# end Enhancement #6306 ============================================

	@total_posts = case @node_type
	when 'note'
	@notes.count
	when 'questions'
	@questions.count
	when 'wiki'
	@wikis.count
	when 'maps'
	@nodes.count
	end
	end
	end

Update tag_controller.rb #8221

Update tag_controller.rb #8221

Conversation

yusufatalay commented Jul 31, 2020 • edited

welcome bot commented Jul 31, 2020

gitpod-io bot commented Jul 31, 2020 • edited

yusufatalay commented Jul 31, 2020

codecov bot commented Jul 31, 2020 • edited

Codecov Report

cesswairimu commented Aug 3, 2020

cesswairimu commented Aug 10, 2020

yusufatalay commented Aug 10, 2020 • edited

avats-dev commented Aug 27, 2020

avats-dev left a comment

Choose a reason for hiding this comment

avats-dev commented Aug 27, 2020

avats-dev commented Aug 27, 2020

yusufatalay commented Aug 27, 2020

avats-dev commented Aug 27, 2020

yusufatalay commented Aug 27, 2020

avats-dev commented Aug 27, 2020

avats-dev left a comment

Choose a reason for hiding this comment

avats-dev commented Aug 30, 2020

avats-dev commented Aug 30, 2020

gitpod-io bot commented Aug 30, 2020

avats-dev left a comment

Choose a reason for hiding this comment

yusufatalay commented Sep 1, 2020

cesswairimu commented Sep 1, 2020

cesswairimu left a comment

Choose a reason for hiding this comment

cesswairimu commented Sep 1, 2020

welcome bot commented Sep 1, 2020

avats-dev commented Sep 1, 2020

yusufatalay commented Jul 31, 2020 •

edited

gitpod-io bot commented Jul 31, 2020 •

edited

codecov bot commented Jul 31, 2020 •

edited

yusufatalay commented Aug 10, 2020 •

edited