Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try another way to change sql_mode #8281

Closed
wants to merge 10 commits into from
Closed

Conversation

icarito
Copy link
Member

@icarito icarito commented Aug 10, 2020

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Aug 10, 2020

testing update

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #8281 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8281   +/-   ##
=======================================
  Coverage   81.44%   81.44%           
=======================================
  Files         101      101           
  Lines        5873     5873           
=======================================
  Hits         4783     4783           
  Misses       1090     1090           

@stale
Copy link

stale bot commented Oct 7, 2020

Hi 馃槃, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 馃帀 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 馃挴 Thank you for your contributions 馃檶 馃巿.

@stale stale bot added stale and removed stale labels Oct 7, 2020
@jywarren
Copy link
Member

I believe this is no longer needed!

@jywarren jywarren closed this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants