Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitpod.dockerfile to fix Mysql in GitPod #8320

Merged
merged 1 commit into from Aug 18, 2020
Merged

Conversation

jywarren
Copy link
Member

Follow-up to #8162 - trying to fix mysql

@gitpod-io
Copy link

gitpod-io bot commented Aug 18, 2020

@jywarren
Copy link
Member Author

Manually confirmed this works in GitPod! Travis experiencing some kind of issue though.

@Tlazypanda
Copy link
Collaborator

Hey @jywarren can we try adding line rm -rf vendor/.bundle/ before bundle config set path 'vendor/.bundle/' to just not take it from the cache so that it does those tasks again in travis. It helped me in solving travis issue last time here https://github.com/publiclab/plots2/pull/8085/files#diff-354f30a63fb0907d4ad57269548329e3R43

@jywarren
Copy link
Member Author

Rebasing over #8322!

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #8320 into main will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8320      +/-   ##
==========================================
+ Coverage   81.28%   81.40%   +0.11%     
==========================================
  Files         101      101              
  Lines        5872     5872              
==========================================
+ Hits         4773     4780       +7     
+ Misses       1099     1092       -7     
Impacted Files Coverage Δ
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@jywarren jywarren merged commit 3c14197 into main Aug 18, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants