New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _profileCard.html.erb #8549
Conversation
i changed the .count to .size on ines 25 to 27
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 10e415e and detected 0 issues on this pull request. View more on Code Climate. |
thanks so much for opening this 馃帀 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks |
Codecov Report
@@ Coverage Diff @@
## main #8549 +/- ##
==========================================
- Coverage 81.91% 81.80% -0.12%
==========================================
Files 101 101
Lines 5896 5896
==========================================
- Hits 4830 4823 -7
- Misses 1066 1073 +7
|
Also please update both files on this pull requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Awesome work, thanks so much! And thanks Cess for the helpful support!!!! |
Congrats on merging your first pull request! 馃檶馃帀鈿★笍 Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
i changed the .count to .size on ines 25 to 27
i changed the .count to .size on ines 25 to 27
i changed the .count to .size on ines 25 to 27
i changed the .count to .size on ines 25 to 27
i changed the .count to .size on ines 25 to 27
i changed the .count to .size on ines 25 to 27
i changed the .count to .size on lines 25 to 27
the link to the changes made :
https://github.com/publiclab/plots2/pull/8549/files
Fixes #8544
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!