Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _profileCard.html.erb #8549

Merged
merged 1 commit into from Oct 16, 2020
Merged

Conversation

amarachi-nwokocha
Copy link
Contributor

@amarachi-nwokocha amarachi-nwokocha commented Oct 12, 2020

i changed the .count to .size on lines 25 to 27
the link to the changes made :
https://github.com/publiclab/plots2/pull/8549/files
Fixes #8544

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

i changed the .count to .size on ines 25 to 27
@welcome
Copy link

welcome bot commented Oct 12, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 12, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2020

Code Climate has analyzed commit 10e415e and detected 0 issues on this pull request.

View more on Code Climate.

@cesswairimu
Copy link
Collaborator

thanks so much for opening this 馃帀 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #8549 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8549      +/-   ##
==========================================
- Coverage   81.91%   81.80%   -0.12%     
==========================================
  Files         101      101              
  Lines        5896     5896              
==========================================
- Hits         4830     4823       -7     
- Misses       1066     1073       +7     
Impacted Files Coverage 螖
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) 猬囷笍
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) 猬囷笍

@cesswairimu
Copy link
Collaborator

Also please update both files on this pull requests

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jywarren
Copy link
Member

Awesome work, thanks so much! And thanks Cess for the helpful support!!!!

@jywarren jywarren merged commit 737f6fa into publiclab:main Oct 16, 2020
@welcome
Copy link

welcome bot commented Oct 16, 2020

Congrats on merging your first pull request! 馃檶馃帀鈿★笍
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 馃槂. Please find the link pinned in the issue section 馃摑
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
i changed the .count to .size on ines 25 to 27
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
i changed the .count to .size on ines 25 to 27
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
i changed the .count to .size on ines 25 to 27
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
i changed the .count to .size on ines 25 to 27
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
i changed the .count to .size on ines 25 to 27
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
i changed the .count to .size on ines 25 to 27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .count with .size on the profileCard partial
3 participants