Replaced paginate for pagy in comments #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| .order('timestamp DESC') | ||
| .where('node.status = ?', 1) | ||
| .paginate(page: params[:page], per_page: 30) | ||
| .where('node.status = ?', 1), items:30) |
Codecov Report
@@ Coverage Diff @@
## main #8599 +/- ##
==========================================
+ Coverage 81.76% 81.88% +0.11%
==========================================
Files 101 101
Lines 5901 5901
==========================================
+ Hits 4825 4832 +7
+ Misses 1076 1069 -7
|
|
Code Climate has analyzed commit f39ba13 and detected 0 issues on this pull request. View more on Code Climate. |
|
Hello @Tlazypanda, I replaced paginate for pagy in comments as well, hope that's okay. Kindly review it if it's okay |
Tlazypanda
approved these changes
Oct 17, 2020
cesswairimu
approved these changes
Oct 19, 2020
|
Thanks you both 馃帀 |
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
* Replaced paginate for pagy * Replaced paginate for pagy
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* Replaced paginate for pagy * Replaced paginate for pagy
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* Replaced paginate for pagy * Replaced paginate for pagy
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* Replaced paginate for pagy * Replaced paginate for pagy
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
* Replaced paginate for pagy * Replaced paginate for pagy
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* Replaced paginate for pagy * Replaced paginate for pagy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8426 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!