-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pagy to user tags #8635
Added pagy to user tags #8635
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8635 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 101 101
Lines 5901 5901
=======================================
Hits 4825 4825
Misses 1076 1076
|
Hello @cesswairimu I found another paginate usage in user tags. Also, I need help in understanding the failed test. Thankyou |
Lets try and restart @stacytonui |
Hi @stacytonui the build error is related to the pagination changes.. where
When I tried running your changes on the Gitpod, I encountered the same thing... I looked at the documentation and I made those changes on your files on Gitpod and the error I encountered was no longer there
Note that Once you do that the build will stop failing 🎉 |
Wow @RuthNjeri such a lifesaver!..Thank you so much |
Code Climate has analyzed commit 9fa95a2 and detected 0 issues on this pull request. View more on Code Climate. |
Wow, tremendous! A tough set of changes and you got it passing the tests! Many thanks also to @RuthNjeri for the deep research here. Great work both of you! |
Congrats!!! |
* Added pagy to user tags * Pagy * Pagy * Pagy * remove whitespaces * pagy_array
Nice one @stacytonui @RuthNjeri |
* Added pagy to user tags * Pagy * Pagy * Pagy * remove whitespaces * pagy_array
* Added pagy to user tags * Pagy * Pagy * Pagy * remove whitespaces * pagy_array
* Added pagy to user tags * Pagy * Pagy * Pagy * remove whitespaces * pagy_array
* Added pagy to user tags * Pagy * Pagy * Pagy * remove whitespaces * pagy_array
* Added pagy to user tags * Pagy * Pagy * Pagy * remove whitespaces * pagy_array
Fixes #8426 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!