New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed value of Finder in constants.rb #8972
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 90ccc99 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8972 +/- ##
=======================================
Coverage ? 81.93%
=======================================
Files ? 100
Lines ? 5950
Branches ? 0
=======================================
Hits ? 4875
Misses ? 1075
Partials ? 0 |
@cesswairimu Kindly review the changes :-) |
Thanks @frappelatte28 for working on this..so the failing test is this
which doesn't seem to be related to this...I will reopen the PR see if that solves it. |
That did the trick @gauravahlawat81 kindly review this. Thanks |
@cesswairimu This can be merged now, all the tests have passed and the changes looks good to me. Thanks @frappelatte28 for working on this! |
Thanks @gauravahlawat81 🎉 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thanks @cesswairimu , and congratulations @frappelatte28 for getting your first PR merged. Welcome to Public lab 💯 |
@cesswairimu We can close #7675 as well. |
Thank you @cesswairimu @gauravahlawat81 for your support! |
yeah @gauravahlawat81 just waiting to test on https://stable.publiclab.org/ and then we can close |
Fixes #8947
rake test
@publiclab/reviewers
for help, in a comment below