Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed value of Finder in constants.rb #8972

Merged
merged 1 commit into from Jan 8, 2021

Conversation

frappelatte28
Copy link
Contributor

Fixes #8947

  • [x ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [x ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [x ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Jan 7, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Jan 7, 2021

@codeclimate
Copy link

codeclimate bot commented Jan 7, 2021

Code Climate has analyzed commit 90ccc99 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@2f7aeac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8972   +/-   ##
=======================================
  Coverage        ?   81.93%           
=======================================
  Files           ?      100           
  Lines           ?     5950           
  Branches        ?        0           
=======================================
  Hits            ?     4875           
  Misses          ?     1075           
  Partials        ?        0           

@frappelatte28
Copy link
Contributor Author

@cesswairimu Kindly review the changes :-)

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jan 8, 2021

Thanks @frappelatte28 for working on this..so the failing test is this

Progress: | FAIL["test_graph", #<Minitest::Reporters::Suite:0x000055ca495503e8 @name="TagSelectionTest">, 0.4641045020000547]
 test_graph#TagSelectionTest (0.46s)
        Expected: 16
          Actual: 20
        test/unit/tag_selection_test.rb:14:in `block in <class:TagSelectionTest>'

which doesn't seem to be related to this...I will reopen the PR see if that solves it.

@cesswairimu cesswairimu closed this Jan 8, 2021
@cesswairimu cesswairimu reopened this Jan 8, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jan 8, 2021

@cesswairimu
Copy link
Collaborator

That did the trick @gauravahlawat81 kindly review this. Thanks

@gauravahlawat81
Copy link
Member

@cesswairimu This can be merged now, all the tests have passed and the changes looks good to me. Thanks @frappelatte28 for working on this!

@cesswairimu
Copy link
Collaborator

Thanks @gauravahlawat81 🎉

@cesswairimu cesswairimu merged commit 6452fc2 into publiclab:main Jan 8, 2021
@welcome
Copy link

welcome bot commented Jan 8, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@gauravahlawat81
Copy link
Member

Thanks @cesswairimu , and congratulations @frappelatte28 for getting your first PR merged. Welcome to Public lab 💯

@gauravahlawat81
Copy link
Member

@cesswairimu We can close #7675 as well.

@frappelatte28
Copy link
Contributor Author

Thank you @cesswairimu @gauravahlawat81 for your support!

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jan 8, 2021

yeah @gauravahlawat81 just waiting to test on https://stable.publiclab.org/ and then we can close

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External links containing an @ at symbol currently parse as public lab usernames
3 participants