Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header button toolbar fix for responsive layouts #9343

Merged
merged 1 commit into from Mar 23, 2021

Conversation

waridrox
Copy link
Member

@waridrox waridrox commented Mar 21, 2021

Fixes #9342

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshot 2021-03-21 at 7 58 51 PM

@noi5e kindly review this. Thanks :)

@waridrox waridrox requested a review from a team as a code owner March 21, 2021 14:01
@gitpod-io
Copy link

gitpod-io bot commented Mar 21, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 21, 2021

Code Climate has analyzed commit 37796b8 and detected 0 issues on this pull request.

View more on Code Climate.

@govindgoel
Copy link
Member

@waridrox Can you share a screenshot or recording of changes

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@27a9787). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9343   +/-   ##
=======================================
  Coverage        ?   78.14%           
=======================================
  Files           ?       98           
  Lines           ?     5870           
  Branches        ?        0           
=======================================
  Hits            ?     4587           
  Misses          ?     1283           
  Partials        ?        0           

@waridrox
Copy link
Member Author

@waridrox Can you share a screenshot or recording of changes

I've shared those in the issue itself...Here's the final output ^^

Copy link
Contributor

@noi5e noi5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! 🎉

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉 thanks for working on this @waridrox

Thanks @noi5e and @govindgoel for the reviews

@cesswairimu cesswairimu merged commit 2587987 into publiclab:main Mar 23, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Insert Header" Toolbar Button Responsive Styling
4 participants