Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functional and system tests for preventing adding tags by first-time-posters #9851

Merged
merged 1 commit into from Jun 27, 2021
Merged

functional and system tests for preventing adding tags by first-time-posters #9851

merged 1 commit into from Jun 27, 2021

Conversation

17sushmita
Copy link
Member

Fixes #9850

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Jun 23, 2021

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2021

Code Climate has analyzed commit f8cb5c7 and detected 0 issues on this pull request.

View more on Code Climate.

@17sushmita 17sushmita requested a review from jywarren June 23, 2021 21:46
@codecov
Copy link

codecov bot commented Jun 23, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@43acd66). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7cd15cf differs from pull request most recent head f8cb5c7. Consider uploading reports for the commit f8cb5c7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9851   +/-   ##
=======================================
  Coverage        ?   79.58%           
=======================================
  Files           ?       98           
  Lines           ?     5962           
  Branches        ?        0           
=======================================
  Hits            ?     4745           
  Misses          ?     1217           
  Partials        ?        0

@17sushmita 17sushmita added gsoc testing issues are usually for adding unit tests, integration tests or any other tests for a feature labels Jun 25, 2021
cesswairimu
cesswairimu approved these changes Jun 27, 2021
View reviewed changes
Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests 🚀 🚀 thanks @17sushmita

@cesswairimu cesswairimu merged commit bd7e6bf into publiclab:main Jun 27, 2021
@jywarren
Copy link
Member

Great work!!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@17sushmita @reginaalyssa
functional and system tests for preventing adding tags by first-time-…
cbcf45f 
…posters (publiclab#9851)
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@17sushmita @billymoroney1
functional and system tests for preventing adding tags by first-time-…
71b07bf 
…posters (publiclab#9851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesswairimu cesswairimu cesswairimu approved these changes

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
gsoc testing issues are usually for adding unit tests, integration tests or any other tests for a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functional and System tests for Preventing first-time-posters to add tags
3 participants
@17sushmita @jywarren @cesswairimu