Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _form.html.erb to fix #9934 #9938

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Update _form.html.erb to fix #9934 #9938

merged 3 commits into from
Jul 26, 2021

Conversation

Pandademic
Copy link
Contributor

Fixes: #9934
Issue:#9934

@welcome
Copy link

welcome bot commented Jul 21, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2021

@Pandademic
Copy link
Contributor Author

@publiclab/reviewers I need help

@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #9938 (bf93fba) into main (e180447) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head bf93fba differs from pull request most recent head 93156da. Consider uploading reports for the commit 93156da to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9938      +/-   ##
==========================================
- Coverage   82.25%   82.13%   -0.12%     
==========================================
  Files          98       98              
  Lines        5968     5968              
==========================================
- Hits         4909     4902       -7     
- Misses       1059     1066       +7
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

imajit
imajit reviewed Jul 21, 2021
View reviewed changes
mychanges/img/Readme Outdated
@@ -0,0 +1 @@
Screenshots for my changes are stored here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to share screenshots of the changes? if so you can add them in the comments of your PR instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually having trouble running the files to take the screenshots

Copy link
Contributor

@imajit imajit Jul 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run your changes in Gitpod, it is similar to local environment #9938 (comment)

@imajit
Copy link
Contributor

imajit commented Jul 21, 2021

Hello @Pandademic , Welcome to Public Lab, and congrats on your first PR 🚀 🚀 🚀
I see some of the tests are failing, maybe you can retry by changing the form file only and adding the screenshots as comments.
Feel free to tag me or any other reviewers if you are still stuck.

@Pandademic
Copy link
Contributor Author

Pandademic commented Jul 21, 2021 •
edited
Loading

Ok thanks @imajit

@Pandademic
Copy link
Contributor Author

Hi @imajit,Should I pull again with only the modified file and the images as comments?

@imajit
Copy link
Contributor

imajit commented Jul 21, 2021

You can commit new changes to this PR without pulling.

@codeclimate
Copy link

codeclimate bot commented Jul 22, 2021

Code Climate has analyzed commit 93156da and detected 0 issues on this pull request.

View more on Code Climate.

@Pandademic
Copy link
Contributor Author

Ok great ,thanks!

@Pandademic
Copy link
Contributor Author

I am really sorry if this sounds stupid but how to I run this in gitpod? 😅

@imajit
Copy link
Contributor

imajit commented Jul 24, 2021

You can click here and once the code is loaded, you will see an option on the bottom rigth corner to open browser view.

Tlazypanda
Tlazypanda approved these changes Jul 24, 2021
View reviewed changes
Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pandademic Great work 🎉 looks like all the tests are passing now

@Pandademic
Copy link
Contributor Author

Thank you @Tlazypanda

@Pandademic
Copy link
Contributor Author

Ok thanks @imajit

@noi5e
Copy link
Contributor

noi5e commented Jul 26, 2021

@Pandademic This looks great!!! Thanks so much for your first contribution, and welcome to Public Lab! Merging now.

@noi5e noi5e merged commit f41f8e7 into publiclab:main Jul 26, 2021
@welcome
Copy link

welcome bot commented Jul 26, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@Pandademic
Copy link
Contributor Author

Thank you!

@jywarren jywarren mentioned this pull request Jul 28, 2021
Closed
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@Pandademic @reginaalyssa
Update _form.html.erb to fix publiclab#9934 (publiclab#9938)
66f7096 
* Update _form.html.erb

* Create Readme

* Delete mychanges/img directory
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@Pandademic @billymoroney1
Update _form.html.erb to fix publiclab#9934 (publiclab#9938)
b118511 
* Update _form.html.erb

* Create Readme

* Delete mychanges/img directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imajit imajit imajit left review comments

@Tlazypanda Tlazypanda Tlazypanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix profile tag input bar
4 participants
@Pandademic @imajit @noi5e @Tlazypanda