New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Contributors" String to Translation Function Call #9952
Conversation
Change "Contributors" String to Translation Function Call publiclab#9949
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 36980a2 and detected 0 issues on this pull request. View more on Code Climate. |
Change "Contributors" String to Translation Function Call #9949 Fixes #0000 (<=== Add issue number here) Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
If tests do fail, click on the red Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Thanks! |
@puliclab/reviewers please Review this Pull request. |
Thank you @hrishikeshnikam2000 Great work! |
So @publiclab/navbar-maintainers will have a look and then this pull request will be merged right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hrishikeshnikam2000 LGTM 馃帀 Yes the Pr will be merged as soon as the approvals are in place. Thank you for your contribution 馃帀 Thanks @imajit for the review 鉁岋笍
Congrats on merging your first pull request! 馃檶馃帀鈿★笍 Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Change "Contributors" String to Translation Function Call publiclab#9949
Change "Contributors" String to Translation Function Call publiclab#9949
Change "Contributors" String to Translation Function Call #9949
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!