Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Contributors" String to Translation Function Call #9952

Merged
merged 1 commit into from Aug 3, 2021

Conversation

hrishikeshnikam2000
Copy link
Contributor

@hrishikeshnikam2000 hrishikeshnikam2000 commented Jul 27, 2021

Change "Contributors" String to Translation Function Call #9949

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Change "Contributors" String to Translation Function Call publiclab#9949
@hrishikeshnikam2000 hrishikeshnikam2000 requested a review from a team as a code owner July 27, 2021 07:46
@welcome
Copy link

welcome bot commented Jul 27, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃

@gitpod-io
Copy link

gitpod-io bot commented Jul 27, 2021

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2021

Code Climate has analyzed commit 36980a2 and detected 0 issues on this pull request.

View more on Code Climate.

@hrishikeshnikam2000
Copy link
Contributor Author

Change "Contributors" String to Translation Function Call #9949

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@hrishikeshnikam2000
Copy link
Contributor Author

@puliclab/reviewers please Review this Pull request.
Also, this is my first time contributing to this project, so please let me know if there is anything I should keep in my mind

@imajit
Copy link
Contributor

imajit commented Jul 27, 2021

Thank you @hrishikeshnikam2000 Great work!
Welcome to Public Lab and congratulations on your first contribution to Public Lab 馃殌 馃殌 馃殌

@hrishikeshnikam2000
Copy link
Contributor Author

So @publiclab/navbar-maintainers will have a look and then this pull request will be merged right?
Also, thank you for being this patient :)

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrishikeshnikam2000 LGTM 馃帀 Yes the Pr will be merged as soon as the approvals are in place. Thank you for your contribution 馃帀 Thanks @imajit for the review 鉁岋笍

@Tlazypanda Tlazypanda merged commit d3c29e7 into publiclab:main Aug 3, 2021
@welcome
Copy link

welcome bot commented Aug 3, 2021

Congrats on merging your first pull request! 馃檶馃帀鈿★笍
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 馃槂. Please find the link to our latest check-in here 馃摑
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Change "Contributors" String to Translation Function Call publiclab#9949
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Change "Contributors" String to Translation Function Call publiclab#9949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants