Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space in the button for clarity #88 #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giovannipr
Copy link

@giovannipr giovannipr commented Nov 1, 2019

Fixes #88

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers or the user who published the issue for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help!

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Copy link

@CodeSarthak CodeSarthak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for opening this pull request @giovannipr 馃槂
Can you please attach a screenshot with the added space to show how it looks now?

Copy link
Contributor

@pythongiant pythongiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you have a look at the conflicts? thanks.

Copy link

@syobonpastel syobonpastel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good.

@LeoDog896
Copy link

It looks fine! It would be nice if you can post screenshots of the change and resolve the conflict below.

This was referenced Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add space in the button for clarity
5 participants