Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping spectral-workbench.js to v0.1.0 and dropping Jasmine tests #378

Merged
merged 1 commit into from Jun 21, 2016

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Jun 21, 2016

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer
  • manual testing

@icarito - I noticed the tests were a lot more verbose -- was there a debug flag set somewhere, or is it just my local env?

This should be manually tested as well, as it integrates some major changes from SpectralWorkbench.js v0.1.0

@jywarren jywarren merged commit 6fadf4e into publiclab:master Jun 21, 2016
@icarito
Copy link
Member

icarito commented Jun 21, 2016

There's no debug setting set at all. Perhaps you've disabled warnings in your dev environment?

@jywarren
Copy link
Member Author

Hmm, take a look - it's extremely verbose on Travis too:
https://travis-ci.org/publiclab/spectral-workbench/builds/139235241 -- what
do you think?

On Tue, Jun 21, 2016 at 5:36 PM, Sebastian Silva notifications@github.com
wrote:

There's no debug setting set at all. Perhaps you've disabled warnings in
your dev environment?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#378 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABfJ9RMTNPjfRj8I2_2y9itoFQcAb-_ks5qOAUUgaJpZM4I6jmm
.

@icarito
Copy link
Member

icarito commented Jun 21, 2016

Okay I see what's going on. You and the testing environment is using a different environment setting: config/environments is where they are configured. One may disable warnings but ultimately I think they are a good thing to have for our code (but not dependencies). I'll look for an option to disable warnings for dependencies.

@jywarren
Copy link
Member Author

Ah, ok, excellent, thanks! Btw with both swb repos using CI, today's
deployment was really smooth and excellent -- thanks!
On Jun 21, 2016 6:08 PM, "Sebastian Silva" notifications@github.com wrote:

Okay I see what's going on. You and the testing environment is using a
different environment setting: config/environments is where they are
configured. One may disable warnings but ultimately I think they are a good
thing to have for our code (but not dependencies). I'll look for an option
to disable warnings for dependencies.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#378 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABfJ3xqomgicJmAI-15UoznsVICPybwks5qOAyVgaJpZM4I6jmm
.

@jywarren
Copy link
Member Author

I found here some good guides on managing warnings:
http://stackoverflow.com/questions/5591509/suppress-ruby-warnings-when-running-specs
-- some are set in environment variables.

On Tue, Jun 21, 2016 at 6:13 PM, Jeffrey Warren jeff@unterbahn.com wrote:

Ah, ok, excellent, thanks! Btw with both swb repos using CI, today's
deployment was really smooth and excellent -- thanks!
On Jun 21, 2016 6:08 PM, "Sebastian Silva" notifications@github.com
wrote:

Okay I see what's going on. You and the testing environment is using a
different environment setting: config/environments is where they are
configured. One may disable warnings but ultimately I think they are a good
thing to have for our code (but not dependencies). I'll look for an option
to disable warnings for dependencies.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#378 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABfJ3xqomgicJmAI-15UoznsVICPybwks5qOAyVgaJpZM4I6jmm
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants