Rails 5.2 + Yarn + Tests + Static routing and more #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntax changes and error fixes
fix integration tests and more syntax changes to fix errors
Revert "fix few functional tests" This reverts commit 5394a08b8c4bfbb08ea89f7e13dd8a45df637bf6. fix some functional tests
fix few functional tests
Upgrading ruby, node and rails version
Add SimpleCov for coverage monitoring
Fix test fixtures
Add comments tests
… into feat/rails5
Using Yarn in favor of Bower
Upgrade: Rails 5.2 + Yarn + Tests + Static routes
alaxalves
force-pushed
the
development
branch
2 times, most recently
from
e1397d6
to
95c2d38
Compare
jywarren
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Wow! This is a @Souravirus - level project! Amazing!!!!! I've reviewed and this looks perfect. I've confirmed manual testing too:
|
What do you think, @alaxalves should I merge this? 🎉 |
Let's wait if others get the chance to review this. Maybe they find something weird |
|
🎉🎉🎉🎉 |
|
Hooooraaayyy !!! |
cesswairimu
reviewed
Aug 1, 2020
|
hey https://github.com/publiclab/spectral-workbench/blame/main/script/start.sh#L19 this is wiping our database on deployment! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake testPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
Thanks!