Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up GitPod #540

Merged
merged 8 commits into from Aug 25, 2020
Merged

Setting up GitPod #540

merged 8 commits into from Aug 25, 2020

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented Aug 18, 2020 •
edited

Available at: https://fac31da2-a42d-4cdb-9c3b-c7c41682cda1.ws-us02.gitpod.io/#/workspace/spectral-workbench

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

@publiclab publiclab deleted a comment from gitpod-io bot Aug 19, 2020
@publiclab publiclab deleted a comment from gitpod-io bot Aug 19, 2020
@publiclab publiclab deleted a comment from gitpod-io bot Aug 19, 2020
@publiclab publiclab deleted a comment from gitpod-io bot Aug 19, 2020
@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2020

@alaxalves
Copy link
Member Author

Working like a charm :)
image

cesswairimu
cesswairimu approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works really good. Fantastic job 🚀

@jywarren
Copy link
Member

Wow amazing!!!! Great work @alaxalves. Should we merge this before or after #539 ?

@jywarren jywarren merged commit 7d34da4 into main Aug 25, 2020
@alaxalves alaxalves deleted the feat/gitpod branch August 25, 2020 14:33
@alaxalves
Copy link
Member Author

Before please

@jywarren jywarren mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesswairimu cesswairimu cesswairimu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alaxalves @jywarren @cesswairimu