Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge WebPros domains in the same section #2013

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

atoomic
Copy link
Contributor

@atoomic atoomic commented Jun 26, 2024

cPanel, Plesk are part of the same WebPros family
merge all domains together as a single organization entry.

Also note that this change is dropping on purpose the wildcard for cprapid as this is not needed and we want to be able to store cookies on x.cprapid.com sub domain.

view comment from #1957 (comment)

make test output

PASS: libpsl_icu_load_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       common.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-public
  CCLD     test-is-public-all
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-cookie-domain-acceptable
PASS: test-is-public
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

@dnsguru
Copy link
Member

dnsguru commented Jun 27, 2024

comment: Same Submitter as prior PR

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .page domains should sort below the .host

Say Hi to Jan Löffler and Kelli Grey for me

@dnsguru dnsguru added the ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important label Jun 27, 2024
@dnsguru dnsguru added this to To-Do in List Add/Mod/Del via automation Jun 27, 2024
cPanel, Plesk are part of the same WebPros family
merge all domains together as a single organization entry.

Also note that this change is dropping on purpose the wildcard for cprapid
as this is not needed and we want to be able to store cookies on
x.cprapid.com sub domain.
@atoomic
Copy link
Contributor Author

atoomic commented Jun 27, 2024

Thanks @dnsguru this is now fixed :-)

@atoomic atoomic requested a review from dnsguru June 27, 2024 05:35
@dnsguru dnsguru self-assigned this Jun 27, 2024
@simon-friedberger
Copy link
Contributor

Thank you for this cleanup!
Quick reminder: domains are supposed to keep a validity of >2y, that's is currently not the case for any of your old domains.

@simon-friedberger simon-friedberger added ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important and removed ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Jun 28, 2024
List Add/Mod/Del automation moved this from To-Do to In Progress Jun 28, 2024
@dnsguru dnsguru added ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=dnsguru Marked as approved and ready to merge by @dnsguru labels Jun 28, 2024
@dnsguru dnsguru merged commit 46db44e into publicsuffix:master Jun 28, 2024
1 check passed
List Add/Mod/Del automation moved this from In Progress to Done or Won't Jun 28, 2024
@atoomic
Copy link
Contributor Author

atoomic commented Jun 28, 2024

Thanks for noticing that >2y issue, I will request to fix that, then update this PR once the update is performed.

Reported and tracked internally as https://servicedesk.webpros.com/hc/en-us/requests/21598

@atoomic
Copy link
Contributor Author

atoomic commented Jul 10, 2024

@simon-friedberger the expiration time for the domains above are now >2yo as expected

> for d in cprapid.com pleskns.com wp2.host pdns.page plesk.page wpsquared.site; do echo -n "Domain $d: "; whois $d | grep Expiry; done
Domain cprapid.com:    Registry Expiry Date: 2030-05-16T21:16:20Z
Domain pleskns.com:    Registry Expiry Date: 2028-06-05T02:57:13Z
Domain wp2.host: Registry Expiry Date: 2030-04-04T23:59:59.0Z
Domain pdns.page: Registry Expiry Date: 2028-03-18T06:47:39Z
Domain plesk.page: Registry Expiry Date: 2028-03-18T03:06:27Z
Domain wpsquared.site: Registry Expiry Date: 2027-06-20T23:59:59.0Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=dnsguru Marked as approved and ready to merge by @dnsguru ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
List Add/Mod/Del
  
Done or Won't
Development

Successfully merging this pull request may close these issues.

None yet

3 participants