-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge WebPros domains in the same section #2013
Conversation
comment: Same Submitter as prior PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .page domains should sort below the .host
Say Hi to Jan Löffler and Kelli Grey for me
cPanel, Plesk are part of the same WebPros family merge all domains together as a single organization entry. Also note that this change is dropping on purpose the wildcard for cprapid as this is not needed and we want to be able to store cookies on x.cprapid.com sub domain.
Thanks @dnsguru this is now fixed :-) |
Thank you for this cleanup! |
Thanks for noticing that >2y issue, I will request to fix that, then update this PR once the update is performed. Reported and tracked internally as https://servicedesk.webpros.com/hc/en-us/requests/21598 |
@simon-friedberger the expiration time for the domains above are now >2yo as expected
|
cPanel, Plesk are part of the same WebPros family
merge all domains together as a single organization entry.
Also note that this change is dropping on purpose the wildcard for cprapid as this is not needed and we want to be able to store cookies on x.cprapid.com sub domain.
view comment from #1957 (comment)
make test output