Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add series order link to series and new post selected series #612

Closed
stevejburge opened this issue Sep 13, 2022 · 6 comments · Fixed by #645
Closed

Add series order link to series and new post selected series #612

stevejburge opened this issue Sep 13, 2022 · 6 comments · Fixed by #645

Comments

@stevejburge
Copy link
Member

I've seen several situations where two parts can share the same number. For example: #611

Should we make this impossible?

@olatechpro
Copy link
Collaborator

olatechpro commented Sep 14, 2022

Not sure if any work needed to be done on this unless I didn't understand the issue.

If "Automatic Numbering" is disabled, the user can use any numbering they want which includes using same part for as many series as they want.

@stevejburge

@stevejburge
Copy link
Member Author

@olatechpro My thought is that it makes no sense for more than one post to be "Part 10", or another number

Every part number should be unique

@olatechpro
Copy link
Collaborator

That shows we're going back to a problem we fixed by adding that "Automatic Numbering" settings which is inability to make changes easily.

For example, if Part 10 exist and the user want to have new part 10 then change the previous part 10 later.

If we decide to auto increase to next number, that leads to previous problem with auto series and related issue.

After our previous fix, it's not possible to have same part when automatic numbering is enabled but if disabled, user are responsible for the value but if you don't want this, then make a full proposal of how this should be so it can be noted instead of introducing part bugs we were trying to fix by introducing the settings @stevejburge

@stevejburge
Copy link
Member Author

Thanks @olatechpro. I appreciate this is difficult.

Some ideas:

  1. We just make it impossible for a post to have the same part number. If you try to add a post as "Part 2" and that already exists in the series, there's an error message.

  2. We find more ways to point people to this screen: /edit.php?page=manage-issues&action=part&series_ID=

Maybe this link goes to that screen?
Screen Shot 2022-09-14 at 1 59 51 PM

Maybe we replace the "Icon" column with a link to "Series Order":
Screen Shot 2022-09-14 at 2 03 18 PM

@olatechpro
Copy link
Collaborator

olatechpro commented Sep 14, 2022

@stevejburge This is more complicated than you explain.

How do you think this should happen with error output.

We prevent post submission when creating or updating post with message?

And in quick edit, how does it work?

I’m not sure if this issue what the implementation.

@stevejburge
Copy link
Member Author

stevejburge commented Sep 14, 2022

@olatechpro That's a good point. The error output will be tricky.

Maybe we go all-in on links to the "Series Order" screen. I have two examples above. Here's a possible third example link in the metabox. Next to any selected series, we show a "Series Order" link?
Screen Shot 2022-09-14 at 2 34 21 PM

@olatechpro olatechpro changed the title Should it be impossible for posts to have the same part number? Add existing series part notification Sep 29, 2022
@olatechpro olatechpro changed the title Add existing series part notification Add series order link to series screen Sep 29, 2022
@olatechpro olatechpro changed the title Add series order link to series screen Add series order link to series and new post selected series Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants