Fix cursor reset issue and cancelled effects spawning
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(examples): refactor `subscribe` example Separate `subscribe` example into two to show separately `subscribe` feature and `presence state` maintenance with subscribe.
Fix issue because of which `cursor` is not reset on `Subscription` and `SubscriptionSet` on unsubscribe.
parfeon
added
priority: medium
Added a method to validate the provided subscription token to conform to PubNub time token requirements with precision. refactor(subscription): split `subscribe` method Split the `subscribe` method into two: `subscribe` and `subscribe_with_timetoken`.
Fix issue because of which cancelled effects still asynchronously spawned for processing. feat(subscription): add more types to create `SubscriptionCursor` from Make it possible to crate `SubscriptionCursor` from the string slice. feat(subscription): add methods to manipulate subscriptions in set Add `add_subscriptions(..)` and `sub_subscriptions(..)` to `SubscriptionSet` to make it possible in addition to sets manipulation use list of subscriptions.
…t into refactor/update-docs-examples
parfeon
changed the title
cursor reset issuecursor reset issue and cancelled effects spawning
Xavrax
approved these changes
Feb 7, 2024
|
@pubnub-release-bot release |
…t into refactor/update-docs-examples
techwritermat
approved these changes
Feb 8, 2024
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(subscription): add more types to create
SubscriptionCursorfromMake it possible to create
SubscriptionCursorfrom the string slice.feat(subscription): add methods to manipulate subscriptions in set
Add
add_subscriptions(..)andsub_subscriptions(..)toSubscriptionSetto make it possible in addition to sets manipulation use list of subscriptions.fix(subscribe): fix
cursorreset issueFix issue because of which
cursoris not reset onSubscriptionandSubscriptionSeton unsubscribe.fix(subscription): fix issue with cancelled effects
Fix issue because of which cancelled effects still asynchronously spawned for processing.
docs(inline): change
clienttopubnubin inline docsrefactor(subscribe): add subscription token validation
Added a method to validate the provided subscription token to conform to PubNub time token requirements with precision.
refactor(examples): refactor
subscribeexampleSeparate
subscribeexample into two to show separatelysubscribefeature andpresence statemaintenance with subscribe.