Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement request: arrow tool direction. stamp size and background #7

Closed
hungrysnake opened this issue Aug 15, 2020 · 6 comments
Closed

Comments

@hungrysnake
Copy link

@pubpub-zz amazing. it is exactly what I need. Just 2 comment to add here.

  1. the arrow tool. I am not sure if it is due to my experience with other annotation tool that the arrow usually start with the tail and end with the arrow head. it seems more logical to me when using arrow to point to something.
  2. the number stamp. it would be nice if it comes with a background color to reduce the distraction from the background. it would be even better if there is a option to change the size of the stamp. Perhaps making it smaller.
@pubpub-zz
Copy link
Owner

  1. If you hit twice the arrow tool, you will change the way the arrow is set. I've selected this way first, as it was more natural to select what you want to indicate. I will try when I will have a little of time an option to select which direction to apply first
  2. I've choosed the easiest option about colors. I will make a proposal in the same idea using multiple depress to get different fillings.

PS : Can you mark as solved the original issue you've raised. It may help people to find my fork.

@hungrysnake
Copy link
Author

Absolutely. I didn't aware that the button can be clicked further to change the behavior. Well done.
Another nice to have improvement would be allowing eraser to select an area to remove stroke (select multiple remove). It is particularly useful when the pen stroke is very small.

@pubpub-zz
Copy link
Owner

Hi HungrySnake, can you close also the issue on Geoven's Gink?

@hungrysnake
Copy link
Author

hungrysnake commented Aug 16, 2020 via email

@pubpub-zz pubpub-zz reopened this Aug 16, 2020
pubpub-zz added a commit that referenced this issue Aug 16, 2020
@pubpub-zz
Copy link
Owner

Hi HungrySnake;
Can you have a look at this version bef
ore versioning
ppInk.zip

@hungrysnake
Copy link
Author

It works. Thanks.
Found another strange issue with the arrow but the behavior is not consistent.
I hit me a few times that when I click the arrow, the number stamp got selected. I'm not able to reproduce the issue but it happens at least 3 times today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants