Dev: add laval doi prefix #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idreyn
approved these changes
May 23, 2022
qweliant
pushed a commit
that referenced
this pull request
Jun 2, 2022
qweliant
pushed a commit
that referenced
this pull request
Jun 2, 2022
bump arcadia style to support urls add laval doi prefix (#2039) fix: Don't show a broken 'Create Pub' button when logged out dev: Okay, don't try to lint generated CSS files Implement multiple emails for submissions (#2035) * Implement multiple emails for submissions * move email list validation Appease eslint Pub state management refactor (#1867) * wip * wip * fffffff * sending PubSyncManager softly into that good night * can't sleep * still refactoring * remove several console.log statements * don't comment out Editor * clean up some unused imports * cool * very cool * copy * the hard part of the merge * move pubHeadings into context * some more merge cleanup * Remove obsolete SubmissionTab * more cleanup * make useIdlyUpdatedState better, but also worse * add a comment * history is actually working now * fix very long-standing discussions plugin issue * key -> editorKey and add includeDiscussionsPlugin * be a little more lenient about connection status * don't append empty abstract * disable discussions plugin during Submissions preview * Disable creating anchored discussions in Submission preview * fix insane bug in the History viewer * running the linter feat: Pub title decorations (#2041) * feat: add simple title editor with bold/italics functionality (#2028) * feat: add simple title editor with bold/italics functionality * feat: emit initial value * feat: ssr-ify title editor * feat: htmlTitle migration; begin integrating title editor * feat: integrate editor * feat: remove trailing nbsp * chore: fix no-danger warning * feature: `PubTitle` component (#2040) * feature: PubTitle component * feat: include htmlTitle in pub preview Co-authored-by: Eric McDaniel <eric.g.mcdaniel@gmail.com> * also render HTML titles in Activity tab * fix: bold/italics in firefox * feat: only update on blur; add onBeforeUnload warning * feat: pr feedback Co-authored-by: Ian Reynolds <idreyn@gmail.com> Move dashboard menu creation to `usePageContext()` (#2034) * Menu refactor * cleaning up fix: Storybook TS issues dev: Add memory bump to npm run test Mobile UX improvements (#1995) * Introducing mobile-optimized navigation for dashboard * including a missing import * fix mobile flicker * fix lint issues * fix lint issues with scope picker * actually fix lint issues * Fix occlusion of bottom menu by the mobile browser's default UI during initial page load/scrolling. * style and size bottom menus * remove secondary overview section on mobile * remove secondary overview section on mobile * fix flickering, but may be rendering menus on client * fix row width on collection overviews * overview search on mobile maybe * make dropdown a little more mobile friendly * fixed styling for mobile popover to select dashboard mode * fixed vertical spacing to fit more meaningful content in mobile dash overview * spacing adjustment to dashboard frame header in mobile * animated icons for mobile popover * fixed mobile dashboard view of Pages * fixed Submissions view on mobile dashboard * fixed Members view on mobile dashboard * show member count in dashboard view * fix font size of details on mobile * fix Community Settings view on mobile dashboard * fix Collections Settings view in mobile dashboard * 🎬 brand new mobile header with icons * resurface 'Create Collection' button in Community Overview on mobile dashboard * fix Create Collection popover for mobile view * style Scope Picker in mobile dash menu to look same as mode selector menu * fix border-top appearing on older scope picker, now applies only to bottom menu * remove vertical scrollbar while still allowing scrolling * dev: Run Prettier on styles * more lint cleanup * first pass at unified dashboard navigation * progress on mobile buttons * mobile button nonsense is working great * Menu refactor * cleaning up * use MobileAware for SSR support * remove HeaderControls (was renamed to GlobalControls) * fix shown member count * use shared mobile mixin * use CSS variables for faded CAD * back off of removing all scroll bars * remove empty mobile mixin * remove unused import * use mobile mixin * add some bottom margin to DashboardFrame on mobile * run Prettier * running the linter....... Co-authored-by: Gabriel Stein <g@gabestein.com> Co-authored-by: Ian Reynolds <idreyn@gmail.com> fix: remove border when hovering read-only title editor fix: Restore old margins on bylines fix: Use MobileAware in ResponsiveHeaderButton fix?: Make OverviewRow bylines grey too. Is that right? Maybe a $dark-grey? fix: Okay. I think the OvervieRow styles are right now. fix: Return empty menuItems for isBasePubPub dev: Collection export tool (#1902) * first pass at export but also package lock whyyyyy * first pass at export but also package lock whyyyyy * aaaaaah still packagelock? * get the async stuff right * revert package-lock etc Co-authored-by: Ian Reynolds <idreyn@gmail.com> fix: break-word for <ol> in tables (#2042) dev: Bump prosemirror-pandoc dev: Beg firebase-tools version for test runner (pending Node upgrade) fix: copy text title to html title when updating from dashboard (#2043) fix: correctly save changes to nested externalpublication model on pubedge (#2046)
qweliant
pushed a commit
that referenced
this pull request
Jun 6, 2022
* save changes * add buttons * ok ok is this broke tho??? * ok ok now is this broke tho??? * ok it works * rmv aqua * ok newline char * better * toggle w/ love * merge master bump arcadia style to support urls add laval doi prefix (#2039) fix: Don't show a broken 'Create Pub' button when logged out dev: Okay, don't try to lint generated CSS files Implement multiple emails for submissions (#2035) * Implement multiple emails for submissions * move email list validation Appease eslint Pub state management refactor (#1867) * wip * wip * fffffff * sending PubSyncManager softly into that good night * can't sleep * still refactoring * remove several console.log statements * don't comment out Editor * clean up some unused imports * cool * very cool * copy * the hard part of the merge * move pubHeadings into context * some more merge cleanup * Remove obsolete SubmissionTab * more cleanup * make useIdlyUpdatedState better, but also worse * add a comment * history is actually working now * fix very long-standing discussions plugin issue * key -> editorKey and add includeDiscussionsPlugin * be a little more lenient about connection status * don't append empty abstract * disable discussions plugin during Submissions preview * Disable creating anchored discussions in Submission preview * fix insane bug in the History viewer * running the linter feat: Pub title decorations (#2041) * feat: add simple title editor with bold/italics functionality (#2028) * feat: add simple title editor with bold/italics functionality * feat: emit initial value * feat: ssr-ify title editor * feat: htmlTitle migration; begin integrating title editor * feat: integrate editor * feat: remove trailing nbsp * chore: fix no-danger warning * feature: `PubTitle` component (#2040) * feature: PubTitle component * feat: include htmlTitle in pub preview Co-authored-by: Eric McDaniel <eric.g.mcdaniel@gmail.com> * also render HTML titles in Activity tab * fix: bold/italics in firefox * feat: only update on blur; add onBeforeUnload warning * feat: pr feedback Co-authored-by: Ian Reynolds <idreyn@gmail.com> Move dashboard menu creation to `usePageContext()` (#2034) * Menu refactor * cleaning up fix: Storybook TS issues dev: Add memory bump to npm run test Mobile UX improvements (#1995) * Introducing mobile-optimized navigation for dashboard * including a missing import * fix mobile flicker * fix lint issues * fix lint issues with scope picker * actually fix lint issues * Fix occlusion of bottom menu by the mobile browser's default UI during initial page load/scrolling. * style and size bottom menus * remove secondary overview section on mobile * remove secondary overview section on mobile * fix flickering, but may be rendering menus on client * fix row width on collection overviews * overview search on mobile maybe * make dropdown a little more mobile friendly * fixed styling for mobile popover to select dashboard mode * fixed vertical spacing to fit more meaningful content in mobile dash overview * spacing adjustment to dashboard frame header in mobile * animated icons for mobile popover * fixed mobile dashboard view of Pages * fixed Submissions view on mobile dashboard * fixed Members view on mobile dashboard * show member count in dashboard view * fix font size of details on mobile * fix Community Settings view on mobile dashboard * fix Collections Settings view in mobile dashboard * 🎬 brand new mobile header with icons * resurface 'Create Collection' button in Community Overview on mobile dashboard * fix Create Collection popover for mobile view * style Scope Picker in mobile dash menu to look same as mode selector menu * fix border-top appearing on older scope picker, now applies only to bottom menu * remove vertical scrollbar while still allowing scrolling * dev: Run Prettier on styles * more lint cleanup * first pass at unified dashboard navigation * progress on mobile buttons * mobile button nonsense is working great * Menu refactor * cleaning up * use MobileAware for SSR support * remove HeaderControls (was renamed to GlobalControls) * fix shown member count * use shared mobile mixin * use CSS variables for faded CAD * back off of removing all scroll bars * remove empty mobile mixin * remove unused import * use mobile mixin * add some bottom margin to DashboardFrame on mobile * run Prettier * running the linter....... Co-authored-by: Gabriel Stein <g@gabestein.com> Co-authored-by: Ian Reynolds <idreyn@gmail.com> fix: remove border when hovering read-only title editor fix: Restore old margins on bylines fix: Use MobileAware in ResponsiveHeaderButton fix?: Make OverviewRow bylines grey too. Is that right? Maybe a $dark-grey? fix: Okay. I think the OvervieRow styles are right now. fix: Return empty menuItems for isBasePubPub dev: Collection export tool (#1902) * first pass at export but also package lock whyyyyy * first pass at export but also package lock whyyyyy * aaaaaah still packagelock? * get the async stuff right * revert package-lock etc Co-authored-by: Ian Reynolds <idreyn@gmail.com> fix: break-word for <ol> in tables (#2042) dev: Bump prosemirror-pandoc dev: Beg firebase-tools version for test runner (pending Node upgrade) fix: copy text title to html title when updating from dashboard (#2043) fix: correctly save changes to nested externalpublication model on pubedge (#2046) * made changes, but will it work * it wont * is this, is this...knowledge * is this, is this...ignorance * what is up with changes * generic split but why test why * updated snapshot * ok, the names are bad, but (in italics) are they * th-e un-t-eth-ered * i have untehtered * nifty * its so many comments 😩 * ill never ask for another code review ever Co-authored-by: Gabriel Stein <g@gabestein.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says!
Test plan
¯\(ツ)/¯