Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User popout background images are no longer working #221

Open
quincynyan opened this issue Jun 17, 2024 · 9 comments
Open

User popout background images are no longer working #221

quincynyan opened this issue Jun 17, 2024 · 9 comments

Comments

@quincynyan
Copy link

I've set

--small-user-popout-background-image: url('https://i.imgur.com/v1ODdsv.gif');
--small-user-popout-background-transparency: #00000099;
--small-user-popout-background-image-position: center;
--big-user-popout-background-image: url('https://i.imgur.com/BXr6I0G.gif');
--big-user-popout-background-transparency: #00000099;
--big-user-popout-background-image-position: center;

in :root but they're not showing up in discord.

It looks like the theme uses .userPopout-2j1gM4 and .root-8LYsGj which are not in the latest Discord version anymore.

@WubzyGD
Copy link
Contributor

WubzyGD commented Jun 18, 2024

to my knowledge, the popouts are deprecated for the theme because of discord's user theming. the popout bg feature was around long before you could set your own themes and banners and such. i don't know what puck intends to do moving forward but i think he's just leaving it.

div .userPopoutOuter_d67f56 .userProfileInnerThemedNonPremium_b64fb4 {
  background-image: var(--small-user-popout-background-image);
  background-position: var(--small-user-popout-background-image-position);
  background-size: cover;
}

div .userPopoutOuter_d67f56 .userProfileInnerThemedNonPremium_b64fb4 .userPopoutOverlayBackground__3e7e6 {
  background: var(--small-user-popout-background-transparency);
}

div .userProfileModalOuter__90b4a .userProfileInnerThemedNonPremium_b64fb4 {
  background-image: var(--big-user-popout-background-image);
  background-position: var(--big-user-popout-background-image-position);
  background-size: cover;
}

div .userProfileModalOuter__90b4a .userProfileInnerThemedNonPremium_b64fb4 .userProfileModalOverlayBackground_a5b043 {
 background: var(--big-user-popout-background-transparency);
}

add that to the bottom of your CSS file. it will add popout backgrounds ONLY to popouts of users without theming. doing the themed ones requires a fair bit of headway that i'm not feeling geared up to go through.

@quincynyan
Copy link
Author

quincynyan commented Jun 25, 2024

Sorry I'm a week late OwO. It looks like the latest update changed the class names and the code you provided is not working.

But yes, I just want to theme non-nitro users, because the grey color is really out of place with my pink background. (Separate issue: when replying somebody, the reply tab, and also the "jump to present message" tab are still grey and unstyled)

@puckzxz
Copy link
Owner

puckzxz commented Jun 25, 2024

Sorry I'm a week late OwO. It looks like the latest update changed the class names and the code you provided is not working.

But yes, I just want to theme non-nitro users, because the grey color is really out of place with my pink background. (Separate issue: when replying somebody, the reply tab, and also the "jump to present message" tab are still grey and unstyled)

Try this

div .userPopoutOuter_c69a7b .userProfileInnerThemedNonPremium_c69a7b {
  background-image: var(--small-user-popout-background-image);
  background-position: var(--small-user-popout-background-image-position);
  background-size: cover;
}

div .userPopoutOuter_c69a7b .userProfileInnerThemedNonPremium_c69a7b .userPopoutOverlayBackground_c69a7b {
  background: var(--small-user-popout-background-transparency);
}

div .userProfileModalOuter_c69a7b .userProfileInnerThemedNonPremium_c69a7b {
  background-image: var(--big-user-popout-background-image);
  background-position: var(--big-user-popout-background-image-position);
  background-size: cover;
}

div .userProfileModalOuter_c69a7b .userProfileInnerThemedNonPremium_c69a7b .userProfileModalOverlayBackground_c69a7b {
 background: var(--big-user-popout-background-transparency);
}

@quincynyan
Copy link
Author

Nope, not working. It looks like they removed the NonPremium class, so that all the classes are the same now, whether themed or not?

@WubzyGD
Copy link
Contributor

WubzyGD commented Jun 25, 2024 via email

@quincynyan
Copy link
Author

quincynyan commented Jun 26, 2024

Noticed this in the class names, might help:
image

Edit: For the big popout,
image

We're trying to select the inner second div right?

@quincynyan
Copy link
Author

This fixed it

div .userProfileOuterUnthemed_c69a7b .userPopoutInner_c69a7b {
  background-image: var(--small-user-popout-background-image);
  background-position: var(--small-user-popout-background-image-position);
  background-size: cover;
}

div .userProfileOuterUnthemed_c69a7b .userPopoutInner_c69a7b .body_b07019 {
  background: var(--small-user-popout-background-transparency);
}

div .userProfileOuterUnthemed_c69a7b .userProfileModalInner_c69a7b {
  background-image: var(--big-user-popout-background-image);
  background-position: var(--big-user-popout-background-image-position);
  background-size: cover;
}

div .userProfileOuterUnthemed_c69a7b .userProfileModalInner_c69a7b .fullSizeOverlayBackground_c69a7b {
 background: var(--big-user-popout-background-transparency);
}

Is puck interested in allowing this in a PR?

@quincynyan
Copy link
Author

Nevermind, why does discord keep changing their code?

image

@WubzyGD
Copy link
Contributor

WubzyGD commented Jul 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants