Fix for read-only file crash #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added import for MutagenError to catch the exception. With these changes no tags are written to the file in the event of a mutagen error, but the trace is still output to the console. A nice addition would be a dialog warning that the files are read-only when trying to write tags. (I am not versed in PyQt, otherwise I would do it myself.) Fixes issue: puddletag#546
sandrotosi
reviewed
Oct 10, 2020
|
I've gotten this to work now, I'll upload the changes today. It's now ready to be merged. |
Also added a conditional to check if the MutagenError is actually a permission error.
|
thanks @blueblots ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added import for MutagenError to catch the exception.
With these changes no tags are written to the file in the
event of a mutagen error, but the trace is still output to
the console.
A nice addition would be a dialog warning that the files areread-only when trying to write tags. (I am not versed in PyQt,
otherwise I would do it myself.)
An error dialog is now displayed when a file has a permission error.
Fixes #546
Fixes #628