Accept multiple file/directory names on commandline #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running from programs such as cmus which expect a tagger to be able to accept more than one filename or directory name. It also makes it more convenient to launch puddletag from the command line for ad-hoc editing of several files. Previously puddletag would simply ignore any non-option arguments after the first one.
sandrotosi
requested changes
Dec 24, 2020
| @@ -348,9 +348,11 @@ if __name__ == '__main__': | |||
|
|
|||
| # Check if dirnames passed on command line. | |||
| if filenames: | |||
| dirname = filenames[0] | |||
| if dirname and os.path.exists(dirname): | |||
| win.openDir(dirname, False) | |||
There was a problem hiding this comment.
It looks like you removed the functionality of specifying a directory?
There was a problem hiding this comment.
No, opening a directory still works. If you run "puddletag dirname" you end up with an array of filenames containing just ["dirname"], and that gets opened here:
win.openFiles(filenames, False)
It loads all the files under that directory, same as before.
|
thanks @GeoffRichards for your contribution to puddletag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running from programs such as cmus which expect a tagger to
be able to accept more than one filename or directory name. It also
makes it more convenient to launch puddletag from the command line for
ad-hoc editing of several files. Previously puddletag would simply
ignore any non-option arguments after the first one.