Fix tagsources get_encoding #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method leans on the html.parser module and that by specification only accepts strings: https://docs.python.org/3/library/html.parser.html#html.parser.HTMLParser.feed It cannot therefore be sensibly used to divine the encoding of a byte-string and this whole block of code is redundant. Likely a carry over from the Python 2 to 3 conversion. Moreover I can find no reference in nay documentation to a FoundEncoding exception and no idea where that is implemented but certainly not by html.parser.
|
Phew, finally coaxed it out of git. git cherrypick be praised. git rebase is a monster. |
|
thanks @bernd-wechner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method leans on the html.parser module and that by specification only accepts strings:
https://docs.python.org/3/library/html.parser.html#html.parser.HTMLParser.feed
It cannot therefore be sensibly used to divine the encoding of a byte-string and this whole block of code is redundant. Likely a carry over from the Python 2 to 3 conversion.
Moreover I can find no reference in nay documentation to a FoundEncoding exception and no idea where that is implemented but certainly not by html.parser.