Filter Fix #690
Merged
Filter Fix #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What `__bool__` is in python v3 was `__nonzero__` in python v2. By renaming these methods, the truth evaluation of the parsed expression in line 204 works again. fixes puddletag#638
When the parser fails to parse the given filter expression, fall back to the simple string based filter. Fixes puddletag#665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter was broken since the Python v2->v3 migration because the name of the method for boolean evaluation changed, and as a result of that the parsed filter expression wasn't properly evaluated but always returned true for any input.
Also fixed a small related issue where un-parsable inputs resulted in a crash. These are now caught and fallback to the simple string search.
Fixes #638 and #665.