About dialogue improvements #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 7f1fa4f the `puddlestuff` package was moved and as a result its relative path/position to the git root changed. The changeset detection has been updated to accommodate the new location. And since I was at it, also replaced the usage of hardcoded `/` with `os.path.join()`, and changed from the `master` branch to `HEAD` which always points to the current commit. The downside is that `HEAD` can contain references, but the upside is that it now also works for tags and all other commits. This solution does not require deps like `gitpython` or assumes the `git` command is avilable (though that would be resonable).
Moved the library versions to its own tab, so we have more space for more and it can be easily copied. And moved the version logic into a separate function, in the hope we can reuse that for e.g. puddletag#552. Also moved the changeset to the line below the puddletag version one. I intentionally did not update the translation resources, since they are minor and there are already translation rework efforts going on.
They now encompass everything from `requirements.in` plus Python and Qt. The version determination first tries to use the new `importlib.metadata` package that was finally added with python v3.10, and falls back to loading the module and reading the `__version__` attribute.
corubba
force-pushed
the
feature/about
branch
from
b4f752b
to
319bde7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix changeset detection
With 7f1fa4f the
puddlestuffpackage was moved and as a result itsrelative path/position to the git root changed. The changeset detection
has been updated to accommodate the new location.
And since I was at it, also replaced the usage of hardcoded
/withos.path.join(), and changed from themasterbranch toHEADwhichalways points to the current commit. The downside is that
HEADcancontain references, but the upside is that it now also works for tags
and all other commits.
This solution does not require deps like
gitpythonor assumes thegitcommand is avilable (though that would be resonable).Slightly reorganize about dialogue
Moved the library versions to its own tab, so we have more space for
more and it can be easily copied. And moved the version logic into a
separate function, in the hope we can reuse that for e.g. #552.
Also moved the changeset to the line below the puddletag version one.
I intentionally did not update the translation resources, since they
are minor and there are already translation rework efforts going on.
Extend dependency versions
They now encompass everything from
requirements.inplus Python and Qt.The version determination first tries to use the new
importlib.metadatapackage that was finally added with python v3.10,and falls back to loading the module and reading the
__version__attribute.