Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes on 'Format value' #702

Merged
merged 1 commit into from Feb 27, 2022
Merged

Fix crashes on 'Format value' #702

merged 1 commit into from Feb 27, 2022

Conversation

nipsufn
Copy link
Contributor

@nipsufn nipsufn commented Feb 20, 2022

Puddletag kept crashing when trying to select "Format Value" (Actions -> Actions / Quick Actions -> Add / Edit -> Add function -> Format Value).
Proposed PR appears to fix the issue.

Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/puddlestuff/actiondlg.py", line 364, in showexample
val = apply_actions([self.func], audio, state, fields)
File "/usr/lib/python3.10/site-packages/puddlestuff/findfunc.py", line 620, in apply_actions
temp = func.runFunction(val, audio, state, None, r_tags)
File "/usr/lib/python3.10/site-packages/puddlestuff/findfunc.py", line 870, in runFunction
return func(**topass)
File "/usr/lib/python3.10/site-packages/puddlestuff/functions.py", line 204, in formatValue
ret = findfunc.parsefunc(p_pattern, m_tags, state=state)
File "/usr/lib/python3.10/site-packages/puddlestuff/findfunc.py", line 462, in parsefunc
func_parsed = run_format_func(func[0], func[1:], m_audio, s_audio, state=state, extra=extra)
File "/usr/lib/python3.10/site-packages/puddlestuff/findfunc.py", line 328, in run_format_func
message = message.arg(arglen_error(e, topass, func, False))
File "/usr/lib/python3.10/site-packages/puddlestuff/findfunc.py", line 71, in arglen_error
raise e
File "/usr/lib/python3.10/site-packages/puddlestuff/findfunc.py", line 322, in run_format_func
ret = func(**topass)
TypeError: replaceWithReg() missing 1 required positional argument: 'repl'
[1] 4305 IOT instruction (core dumped) puddletag -d

@sandrotosi sandrotosi merged commit 97ebaf5 into puddletag:master Feb 27, 2022
@sandrotosi
Copy link
Member

thanks @nipsufn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants