Replace obsolete PyQt5 things #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is replaced by QScreen.
It is more or less drop-in replaced by QFileSystemModel, the only difference is that the sorting is unconfigurable but seems to coincide with what we want.
It is replaced by beginResetModel() and endResetModel(). These are wrapped in a python context manager, so model-resetting code can simply surrounded with a `with` block and ensure that the end method is called even in case of an error. The comment regarding the signal is from 2009, I will *assume* this issue is fixed by now, especially because endResetModel() will also emit the modelReset signal.
It is replaced by horizontalAdvance(QString).
It is replaced with `sortByColumn(int, SortOrder)`.
It is replaced by textActivated.
It is replaced by BackgroundRole.
…obsolete It is replaced by AdjustToContents.
It is replaced by Directory and setting the ShowDirsOnly option.
It is replaced by Window.
|
great work! |
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with every major/minor release, Qt5 and subsequently PyQt5 obsoleted/deprecated a few things (classes, methods, properties, ...) which will be removed with Qt6 and PyQt6. This PR replaces all these obsoleted/deprecated things with their "modern" pendant to future-proof, and preempt instant breakage when moving to PyQt6.