Icon fixes #715
Merged
Icon fixes #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove those that are not actually used anywhere. Some of them are broken to begin with (size of 0 byte).
For some reason `caseconversion.action` and `standard.action` had crossed-over aliases, but since they are always used together it never broke things.
There is a vector version, use that instead of keeping a separate png around. Since I found the `appicon` name more descriptive, use that consistently.
- Moved the svg from the root to the rest of the images - Resized it from weird 464x127 to not-as-much-weird 512x128 pixel - Named the layers and objects more descriptively - Removed the transparency from the background gradient while keeping the resulting colours the same. Also resized it to fit the new size, and made the white border consistently 2px all around - The font used for the app name is `Impossibilium BRK` by Ænigma Fonts (Brian Kent). It can be found freely on the internet, for example here [0] - Created a path copy so you don't need the font installed - Re-centered the text - Updated, repositioned and hid the version text (since it will be outdated soon anyway) - Re-exported the svg to png In theory we could use the svg directly, but the svg renderer in Qt does not support filters [1], which are used to create the backdrop shadow. And since it looks ugly/weird without it, we continue to use a png version. [0] https://www.1001fonts.com/impossibilium-brk-font.html [1] https://bugreports.qt.io/browse/QTBUG-9081
$ pyrcc5 puddlestuff/resource.qrc -o puddlestuff/resource.py
The version was removed from the png, so add it back in on the fly during runtime with the actual version.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of this PR were originally in #687.
Changes
Clean up icons
Remove those that are not actually used anywhere. Some of them are broken to begin with (size of 0 byte).
Fix action aliases
For some reason
caseconversion.actionandstandard.actionhad crossed-over aliases, but since they are always used together it never broke things.Fix appicon
There is a vector version, use that instead of keeping a separate png around. Since I found the
appiconname more descriptive, use that consistently.Update puddlelogo
the resulting colours the same. Also resized it to fit the new size,
and made the white border consistently 2px all around
Impossibilium BRKby Ænigma Fonts(Brian Kent). It can be found freely on the internet, for example
here
outdated soon anyway)
In theory we could use the svg directly, but the svg renderer in Qt does not support filters, which are used to create the backdrop shadow. And since it looks ugly/weird without it, we continue to use a png version.
Recompile resource.py
$ pyrcc5 puddlestuff/resource.qrc -o puddlestuff/resource.pyAdd dynamic version to splashscreen
The version was removed from the png, so add it back in on the fly during runtime with the actual version.
Comparison Splashscreen
Before
After